Re: qla1280 driver for qlogic-1040 on alpha

[Christoph Hellwig <hch@infradead.org>]

On Thu, Oct 31, 2024 at 05:30:31PM +0000, Maciej W. Rozycki wrote:
>  This also means that the ISP_CFG0_1040A check also added in 2.6.9 with 
> <https://lore.kernel.org/r/20040606125825.GE31063@lst.de/> will never 
> match, possibly meaning that this code wasn't actually ever verified with 
> affected 1040A hardware.  This might also explain why a later change made 
> with commit 0888f4c33128 ("[SCSI] qla1280: don't use bitfields for 
> hardware access in isp_config") went unnoticed that changed the semantics 
> of the workaround from keeping bursts unconditionally disabled with the 
> 1040A to making them enabled in the absence of NVRAM.
> 
>  NB comments for the FIFO threshold surely are suspicious too.
> 
>  Christoph can you please have a look into it?  It seems like something 
> you ought to be quite familiar with if not for the passage of time.

Somewhat surprisingly I don't remember that details of a drive by
cleanup 20 years ago :)

So whatever fixes you have based on other implementations are probably
correct.