[PATCH] scsi: pm80xx: Fix the use_msix, use_tasklet and read_wwn parameter descriptions

[PATCH] scsi: pm80xx: Fix the use_msix, use_tasklet and read_wwn parameter descriptions

[Karl Mehltretter]

The MODULE_PARM_DESC() lines of use_msix, use_tasklet and read_wwn all
name a parameter zoned, which does not exist, and the use_tasklet one
repeats the use_msix text. modinfo shows three "zoned" entries and no
description for the real parameters.

Name the right parameters and describe use_tasklet.

Fixes: efa1fca45082 ("scsi: pm8001: Remove PM8001_USE_MSIX")
Fixes: 205430290ad0 ("scsi: pm8001: Remove PM8001_USE_TASKLET")
Fixes: 80975adc79dd ("scsi: pm8001: Remove PM8001_READ_VPD")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Three Fixes: tags because the three lines came from three commits of
the same series, all in v6.7.

 drivers/scsi/pm8001/pm8001_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index e93ea76b565e..b1ea7cf9d605 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -58,15 +58,15 @@ MODULE_PARM_DESC(link_rate, "Enable link rate.\n"
 
 bool pm8001_use_msix = true;
 module_param_named(use_msix, pm8001_use_msix, bool, 0444);
-MODULE_PARM_DESC(zoned, "Use MSIX interrupts. Default: true");
+MODULE_PARM_DESC(use_msix, "Use MSIX interrupts. Default: true");
 
 static bool pm8001_use_tasklet = true;
 module_param_named(use_tasklet, pm8001_use_tasklet, bool, 0444);
-MODULE_PARM_DESC(zoned, "Use MSIX interrupts. Default: true");
+MODULE_PARM_DESC(use_tasklet, "Use tasklets for interrupt handling. Default: true");
 
 static bool pm8001_read_wwn = true;
 module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);
-MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");
+MODULE_PARM_DESC(read_wwn, "Get WWN from the controller. Default: true");
 
 uint pcs_event_log_severity = 0x03;
 module_param(pcs_event_log_severity, int, 0644);

base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
-- 
2.53.0

Re: [PATCH] scsi: pm80xx: Fix the use_msix, use_tasklet and read_wwn parameter descriptions

[Damien Le Moal]

On 9/7/26 02:09, Karl Mehltretter wrote:
> The MODULE_PARM_DESC() lines of use_msix, use_tasklet and read_wwn all
> name a parameter zoned, which does not exist, and the use_tasklet one
> repeats the use_msix text. modinfo shows three "zoned" entries and no
> description for the real parameters.
> 
> Name the right parameters and describe use_tasklet.
> 
> Fixes: efa1fca45082 ("scsi: pm8001: Remove PM8001_USE_MSIX")
> Fixes: 205430290ad0 ("scsi: pm8001: Remove PM8001_USE_TASKLET")
> Fixes: 80975adc79dd ("scsi: pm8001: Remove PM8001_READ_VPD")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] scsi: pm80xx: Fix the use_msix, use_tasklet and read_wwn parameter descriptions

[Martin K. Petersen (Oracle)]

On Sun, 06 Sep 2026 19:09:25 +0200, Karl Mehltretter wrote:

> The MODULE_PARM_DESC() lines of use_msix, use_tasklet and read_wwn all
> name a parameter zoned, which does not exist, and the use_tasklet one
> repeats the use_msix text. modinfo shows three "zoned" entries and no
> description for the real parameters.
> 
> Name the right parameters and describe use_tasklet.
> 
> [...]

Applied to 7.3/scsi-fixes, thanks!

[1/1] scsi: pm80xx: Fix the use_msix, use_tasklet and read_wwn parameter descriptions
      https://git.kernel.org/mkp/scsi/c/264bf9655c3d

-- 
Martin K. Petersen