From: Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Anjana Hari <anjana.hari@oss.qualcomm.com>
Subject: Re: [PATCH V4 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller
Date: Tue, 13 Jan 2026 12:55:13 +0530 [thread overview]
Message-ID: <b50dc9ce-7fb1-46dd-8adf-e58778553934@oss.qualcomm.com> (raw)
In-Reply-To: <20260107-deft-mouflon-of-shopping-baaece@quoll>
On 07-Jan-26 1:08 PM, Krzysztof Kozlowski wrote:
> On Tue, Jan 06, 2026 at 07:10:06PM +0530, Ram Kumar Dwivedi wrote:
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> + ufshc@1d84000 {
>
> Completely messed indentation.
>
> Why did we ask to drop the unnecessary soc node? To make it simpler.
>
> Even if you do not believe that code should be simpler, you should
> immediately spot the odd indentation.
>
> For such trivialities you cannot get this patch merged. It's third
> revision which you send carelessly.
Hi Krzysztof,
Apologies for the oversight. I missed correcting the indentation after removing the 'soc' node wrapper.
I will ensure the example is correctly indented in the next version.
Thanks,
Ram
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-01-13 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 13:40 [PATCH V4 0/4] ufs: ufs-qcom: Add support firmware managed platforms Ram Kumar Dwivedi
2026-01-06 13:40 ` [PATCH V4 1/4] MAINTAINERS: broaden UFS Qualcomm binding file pattern Ram Kumar Dwivedi
2026-01-06 13:40 ` [PATCH V4 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller Ram Kumar Dwivedi
2026-01-07 7:38 ` Krzysztof Kozlowski
2026-01-13 7:25 ` Ram Kumar Dwivedi [this message]
2026-01-06 13:40 ` [PATCH V4 3/4] scsi: ufs: core Enforce minimum pm level for sysfs configuration Ram Kumar Dwivedi
2026-01-06 13:56 ` Bart Van Assche
2026-01-13 7:28 ` Ram Kumar Dwivedi
2026-01-06 14:27 ` Shawn Lin
2026-01-07 16:51 ` Manivannan Sadhasivam
2026-01-06 13:40 ` [PATCH V4 4/4] ufs: ufs-qcom: Add support for firmware-managed resource abstraction Ram Kumar Dwivedi
2026-01-08 4:42 ` Manivannan Sadhasivam
2026-01-13 7:21 ` Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b50dc9ce-7fb1-46dd-8adf-e58778553934@oss.qualcomm.com \
--to=ram.dwivedi@oss.qualcomm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=anjana.hari@oss.qualcomm.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox