From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
"CC Chou (周志杰)" <cc.chou@mediatek.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
"Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Qilin Tan (谭麒麟)" <Qilin.Tan@mediatek.com>,
"Lin Gui (桂林)" <Lin.Gui@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Jiajie Hao (郝加节)" <jiajie.hao@mediatek.com>,
"Tun-yu Yu (游敦聿)" <Tun-yu.Yu@mediatek.com>,
"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>
Subject: Re: [PATCH v1 2/2] ufs: core: support dumping CQ entry in MCQ Mode
Date: Wed, 15 Oct 2025 06:14:58 +0000 [thread overview]
Message-ID: <b9a9157e09cde6ea17f9a0f36a4ad11fcbcf0b0b.camel@mediatek.com> (raw)
In-Reply-To: <4c47f800-0536-452a-b64b-d177fa306418@acm.org>
On Tue, 2025-10-14 at 08:46 -0700, Bart Van Assche wrote:
> So there are four callers of ufshcd_print_tr() and only one caller
> dumps
> the CQE? Wouldn't it be better not to add any arguments to
> ufshcd_print_tr() and instead add the code for dumping the CQE
> directly
> in the only function that needs this functionality?
>
> Thanks,
>
> Bart.
>
>
Hi Bart,
The CQE pointer is generated by the hardware after receiving
the UFS device response. So, if we don't add the CQE argument,
I'm not sure how we could obtain this pointer in ufshcd_print_tr.
Or are you suggesting that we dump the CQE directly in
ufshcd_transfer_rsp_status?
Thanks
Peter
next prev parent reply other threads:[~2025-10-15 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 13:15 [PATCH v1 0/2] update CQ entry and dump CQE in MCQ mode peter.wang
2025-10-14 13:15 ` [PATCH v1 1/2] ufs: core: update CQ Entry to UFS 4.1 format peter.wang
2025-10-14 15:44 ` Bart Van Assche
2025-10-15 5:58 ` Peter Wang (王信友)
2025-10-14 13:15 ` [PATCH v1 2/2] ufs: core: support dumping CQ entry in MCQ Mode peter.wang
2025-10-14 15:46 ` Bart Van Assche
2025-10-15 6:14 ` Peter Wang (王信友) [this message]
2025-10-15 16:00 ` Bart Van Assche
2025-10-16 2:12 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a9157e09cde6ea17f9a0f36a4ad11fcbcf0b0b.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=Alice.Chao@mediatek.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Ed.Tsai@mediatek.com \
--cc=Lin.Gui@mediatek.com \
--cc=Naomi.Chu@mediatek.com \
--cc=Qilin.Tan@mediatek.com \
--cc=Tun-yu.Yu@mediatek.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jiajie.hao@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox