Linux SCSI subsystem development
 help / color / mirror / Atom feed
* scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure
@ 2026-09-02  8:25 pavrampu
  2026-09-02  8:40 ` Venkat Rao Bagalkote
  0 siblings, 1 reply; 4+ messages in thread
From: pavrampu @ 2026-09-02  8:25 UTC (permalink / raw)
  To: tyreld; +Cc: linux-scsi, linuxppc-dev, brking, linux-kernel, davemarq,
	venkat88

Hi,

I am seeing below build failure with latest linux-next repo.

Description:

Building the kernel with CONFIG_SCSI_IBMVFC=y and CONFIG_NVME_FC=m 
results in a link failure when building vmlinux:

Build failure logs:

ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
`ibmvfc_nvme_register_remoteport':
ibmvfc-nvme.c:488: undefined reference to `nvme_fc_register_remoteport'
ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
`ibmvfc_nvme_unregister_remoteport':
ibmvfc-nvme.c:515: undefined reference to 
`nvme_fc_unregister_remoteport'
ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
`ibmvfc_nvme_register':
ibmvfc-nvme.c:536: undefined reference to `nvme_fc_register_localport'
ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
`ibmvfc_nvme_unregister':
ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
`ibmvfc_nvme_unregister':
ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
ld: drivers/scsi/ibmvscsi/ibmvfc-core.c:6798: undefined reference to 
`nvme_fc_rescan_remoteport'

If you happen to fix this, please add below tag.

Reported-by: Pavithra <pavrampu@linux.ibm.com>

Thanks,
Pavithra

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure
  2026-09-02  8:25 scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure pavrampu
@ 2026-09-02  8:40 ` Venkat Rao Bagalkote
  2026-09-03  1:27   ` Tyrel Datwyler
  0 siblings, 1 reply; 4+ messages in thread
From: Venkat Rao Bagalkote @ 2026-09-02  8:40 UTC (permalink / raw)
  To: pavrampu, tyreld; +Cc: linux-scsi, linuxppc-dev, brking, linux-kernel, davemarq


On 02/09/26 1:55 pm, pavrampu wrote:
> Hi,
>
> I am seeing below build failure with latest linux-next repo.
>
> Description:
>
> Building the kernel with CONFIG_SCSI_IBMVFC=y and CONFIG_NVME_FC=m 
> results in a link failure when building vmlinux:
>
> Build failure logs:
>
> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
> `ibmvfc_nvme_register_remoteport':
> ibmvfc-nvme.c:488: undefined reference to `nvme_fc_register_remoteport'
> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
> `ibmvfc_nvme_unregister_remoteport':
> ibmvfc-nvme.c:515: undefined reference to `nvme_fc_unregister_remoteport'
> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
> `ibmvfc_nvme_register':
> ibmvfc-nvme.c:536: undefined reference to `nvme_fc_register_localport'
> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
> `ibmvfc_nvme_unregister':
> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function 
> `ibmvfc_nvme_unregister':
> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
> ld: drivers/scsi/ibmvscsi/ibmvfc-core.c:6798: undefined reference to 
> `nvme_fc_rescan_remoteport'


Below simple check in Kconfig fixes the build failure.

If this is acceptable, then I will send a formal patch.

# git diff
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 4a2af0f702e1..6612d5d445e2 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -753,6 +753,7 @@ config SCSI_IBMVFC
         tristate "IBM Virtual FC support"
         depends on PPC_PSERIES && SCSI
         depends on SCSI_FC_ATTRS
+      depends on NVME_FC || NVME_FC=n
         help
           This is the IBM POWER Virtual FC Client


Regards,

Venkat.

>
> If you happen to fix this, please add below tag.
>
> Reported-by: Pavithra <pavrampu@linux.ibm.com>
>
> Thanks,
> Pavithra

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure
  2026-09-02  8:40 ` Venkat Rao Bagalkote
@ 2026-09-03  1:27   ` Tyrel Datwyler
  2026-09-03  7:46     ` Venkat Rao Bagalkote
  0 siblings, 1 reply; 4+ messages in thread
From: Tyrel Datwyler @ 2026-09-03  1:27 UTC (permalink / raw)
  To: Venkat Rao Bagalkote, pavrampu
  Cc: linux-scsi, linuxppc-dev, brking, linux-kernel, davemarq

On 9/2/26 1:40 AM, Venkat Rao Bagalkote wrote:
> 
> On 02/09/26 1:55 pm, pavrampu wrote:
>> Hi,
>>
>> I am seeing below build failure with latest linux-next repo.
>>
>> Description:
>>
>> Building the kernel with CONFIG_SCSI_IBMVFC=y and CONFIG_NVME_FC=m results in
>> a link failure when building vmlinux:
>>
>> Build failure logs:
>>
>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function
>> `ibmvfc_nvme_register_remoteport':
>> ibmvfc-nvme.c:488: undefined reference to `nvme_fc_register_remoteport'
>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function
>> `ibmvfc_nvme_unregister_remoteport':
>> ibmvfc-nvme.c:515: undefined reference to `nvme_fc_unregister_remoteport'
>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_register':
>> ibmvfc-nvme.c:536: undefined reference to `nvme_fc_register_localport'
>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_unregister':
>> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_unregister':
>> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
>> ld: drivers/scsi/ibmvscsi/ibmvfc-core.c:6798: undefined reference to
>> `nvme_fc_rescan_remoteport'
> 
> 
> Below simple check in Kconfig fixes the build failure.
> 
> If this is acceptable, then I will send a formal patch.

Yep, need to force ibmvfc to be a module when NVME_FC isn't builtin, or NVME_FC
must be disabled.

-Tyrel
> 
> # git diff
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 4a2af0f702e1..6612d5d445e2 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -753,6 +753,7 @@ config SCSI_IBMVFC
>         tristate "IBM Virtual FC support"
>         depends on PPC_PSERIES && SCSI
>         depends on SCSI_FC_ATTRS
> +      depends on NVME_FC || NVME_FC=n
>         help
>           This is the IBM POWER Virtual FC Client
> 
> 
> Regards,
> 
> Venkat.
> 
>>
>> If you happen to fix this, please add below tag.
>>
>> Reported-by: Pavithra <pavrampu@linux.ibm.com>
>>
>> Thanks,
>> Pavithra
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure
  2026-09-03  1:27   ` Tyrel Datwyler
@ 2026-09-03  7:46     ` Venkat Rao Bagalkote
  0 siblings, 0 replies; 4+ messages in thread
From: Venkat Rao Bagalkote @ 2026-09-03  7:46 UTC (permalink / raw)
  To: Tyrel Datwyler, pavrampu
  Cc: linux-scsi, linuxppc-dev, brking, linux-kernel, davemarq


On 03/09/26 6:57 am, Tyrel Datwyler wrote:
> On 9/2/26 1:40 AM, Venkat Rao Bagalkote wrote:
>> On 02/09/26 1:55 pm, pavrampu wrote:
>>> Hi,
>>>
>>> I am seeing below build failure with latest linux-next repo.
>>>
>>> Description:
>>>
>>> Building the kernel with CONFIG_SCSI_IBMVFC=y and CONFIG_NVME_FC=m results in
>>> a link failure when building vmlinux:
>>>
>>> Build failure logs:
>>>
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function
>>> `ibmvfc_nvme_register_remoteport':
>>> ibmvfc-nvme.c:488: undefined reference to `nvme_fc_register_remoteport'
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function
>>> `ibmvfc_nvme_unregister_remoteport':
>>> ibmvfc-nvme.c:515: undefined reference to `nvme_fc_unregister_remoteport'
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_register':
>>> ibmvfc-nvme.c:536: undefined reference to `nvme_fc_register_localport'
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_unregister':
>>> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-nvme.o: in function `ibmvfc_nvme_unregister':
>>> ibmvfc-nvme.c:565: undefined reference to `nvme_fc_unregister_localport'
>>> ld: drivers/scsi/ibmvscsi/ibmvfc-core.c:6798: undefined reference to
>>> `nvme_fc_rescan_remoteport'
>>
>> Below simple check in Kconfig fixes the build failure.
>>
>> If this is acceptable, then I will send a formal patch.
> Yep, need to force ibmvfc to be a module when NVME_FC isn't builtin, or NVME_FC
> must be disabled.


Thank you for confirming.

Link to Patch: 
https://lore.kernel.org/all/20260903074329.6705-1-venkat88@linux.ibm.com/


Regards,

Venkat.

>
> -Tyrel
>> # git diff
>> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
>> index 4a2af0f702e1..6612d5d445e2 100644
>> --- a/drivers/scsi/Kconfig
>> +++ b/drivers/scsi/Kconfig
>> @@ -753,6 +753,7 @@ config SCSI_IBMVFC
>>          tristate "IBM Virtual FC support"
>>          depends on PPC_PSERIES && SCSI
>>          depends on SCSI_FC_ATTRS
>> +      depends on NVME_FC || NVME_FC=n
>>          help
>>            This is the IBM POWER Virtual FC Client
>>
>>
>> Regards,
>>
>> Venkat.
>>
>>> If you happen to fix this, please add below tag.
>>>
>>> Reported-by: Pavithra <pavrampu@linux.ibm.com>
>>>
>>> Thanks,
>>> Pavithra

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-03  7:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02  8:25 scsi: ibmvfc: Add Kconfig dependency on NVME_FC to prevent link failure pavrampu
2026-09-02  8:40 ` Venkat Rao Bagalkote
2026-09-03  1:27   ` Tyrel Datwyler
2026-09-03  7:46     ` Venkat Rao Bagalkote

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox