From: Can Guo <can.guo@oss.qualcomm.com>
To: Bart Van Assche <bvanassche@acm.org>,
avri.altman@wdc.com, beanhuo@micron.com, peter.wang@mediatek.com,
martin.petersen@oracle.com, mani@kernel.org
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
vamshi gajjela <vamshigajjela@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings
Date: Thu, 23 Apr 2026 21:50:10 +0800 [thread overview]
Message-ID: <bda82d6d-0f72-4c9f-8e40-3068be674180@oss.qualcomm.com> (raw)
In-Reply-To: <7daff6c5-a0b6-4d52-a115-98cbb1d9abd9@acm.org>
On 4/21/2026 1:01 AM, Bart Van Assche wrote:
> On 4/19/26 6:52 AM, Can Guo wrote:
>> +#define TX_EQ_DEVICE_PRESHOOT_DECODE(eq, lane) \
>> + (((eq) >> ((lane) * TX_HS_PRESHOOT_SHIFT)) & TX_EQ_SETTING_MASK)
>> +#define TX_EQ_DEVICE_DEEMPHASIS_DECODE(eq, lane) \
>> + (((eq) >> ((lane) * TX_HS_DEEMPHASIS_SHIFT + 16)) &
>> TX_EQ_SETTING_MASK)
>
> Please convert these two macros and also all the other new macros in
> this patch that accept arguments into inline functions.
Will do.
Thanks,
Can Guo.
>
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2026-04-23 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 13:52 [PATCH 0/2] scsi: ufs: Add persistent TX Equalization settings support Can Guo
2026-04-19 13:52 ` [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() Can Guo
2026-04-20 12:31 ` Peter Wang (王信友)
2026-04-20 16:58 ` Bart Van Assche
2026-04-23 12:59 ` Can Guo
2026-04-20 22:04 ` Bean Huo
2026-04-23 13:30 ` Can Guo
2026-04-19 13:52 ` [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings Can Guo
2026-04-20 12:33 ` Peter Wang (王信友)
2026-04-20 13:23 ` Can Guo
2026-04-20 16:28 ` Bart Van Assche
2026-04-23 13:49 ` Can Guo
2026-04-20 17:01 ` Bart Van Assche
2026-04-23 13:50 ` Can Guo [this message]
2026-04-20 22:09 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda82d6d-0f72-4c9f-8e40-3068be674180@oss.qualcomm.com \
--to=can.guo@oss.qualcomm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=rafael.j.wysocki@intel.com \
--cc=vamshigajjela@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox