From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <can.guo@oss.qualcomm.com>,
avri.altman@wdc.com, beanhuo@micron.com, peter.wang@mediatek.com,
martin.petersen@oracle.com, mani@kernel.org
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Keoseong Park <keosung.park@samsung.com>,
Daniel Lee <chullee@google.com>,
Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>,
Huan Tang <tanghuan@vivo.com>, Liu Song <liu.song13@zte.com.cn>,
Bean Huo <huobean@gmail.com>,
vamshi gajjela <vamshigajjela@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword()
Date: Mon, 20 Apr 2026 09:58:18 -0700 [thread overview]
Message-ID: <316c8b28-9e93-4d14-b6d6-e8d593b8627c@acm.org> (raw)
In-Reply-To: <20260419135229.1036926-2-can.guo@oss.qualcomm.com>
On 4/19/26 6:52 AM, Can Guo wrote:
> +static inline bool ufshcd_is_qword_attrs(enum attr_idn idn)
> +{
> + return idn == QUERY_ATTR_IDN_TIMESTAMP ||
> + idn == QUERY_ATTR_IDN_DEV_LVL_EXCEPTION_ID;
> +}
Please change "ufshcd_is_qword_attrs()" into "ufshcd_is_qword_attr()".
> +/**
> + * ufshcd_query_attr_qword - API function of sending query requests for quad-word attributes
> + * @hba: per-adapter instance
> + * @opcode: attribute opcode
> + * @idn: attribute idn to access
> + * @index: index field
> + * @sel: selector field
> + * @attr_val: the attribute value after the query request completes
> + *
> + * Return: 0 for success, non-zero in case of failure.
> + */
The word "API" is uncommon in the first line of kernel-doc headers.
Please remove it.
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2026-04-20 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 13:52 [PATCH 0/2] scsi: ufs: Add persistent TX Equalization settings support Can Guo
2026-04-19 13:52 ` [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() Can Guo
2026-04-20 12:31 ` Peter Wang (王信友)
2026-04-20 16:58 ` Bart Van Assche [this message]
2026-04-23 12:59 ` Can Guo
2026-04-20 22:04 ` Bean Huo
2026-04-23 13:30 ` Can Guo
2026-04-19 13:52 ` [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings Can Guo
2026-04-20 12:33 ` Peter Wang (王信友)
2026-04-20 13:23 ` Can Guo
2026-04-20 16:28 ` Bart Van Assche
2026-04-23 13:49 ` Can Guo
2026-04-20 17:01 ` Bart Van Assche
2026-04-23 13:50 ` Can Guo
2026-04-20 22:09 ` Bean Huo
[not found] <CGME20260421110151epcas2p40628a13eb86c5c9b90626d14efc3b3ba@epcas2p4.samsung.com>
2026-04-21 11:01 ` [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() hoyoung seo
2026-04-23 12:55 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316c8b28-9e93-4d14-b6d6-e8d593b8627c@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=chullee@google.com \
--cc=huobean@gmail.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liu.song13@zte.com.cn \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ram.dwivedi@oss.qualcomm.com \
--cc=tanghuan@vivo.com \
--cc=vamshigajjela@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox