[PATCH] blk-zoned: Document disk_zone_wplug_schedule_bio_work() locking

[PATCH] blk-zoned: Document disk_zone_wplug_schedule_bio_work() locking

[Bart Van Assche]

Document that all callers hold this lock because the code in
disk_zone_wplug_schedule_bio_work() depends on this.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 57ab2b365c2d..5487d5eb2650 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -1188,6 +1188,8 @@ void blk_zone_mgmt_bio_endio(struct bio *bio)
 static void disk_zone_wplug_schedule_bio_work(struct gendisk *disk,
 					      struct blk_zone_wplug *zwplug)
 {
+	lockdep_assert_held(&zwplug->lock);
+
 	/*
 	 * Take a reference on the zone write plug and schedule the submission
 	 * of the next plugged BIO. blk_zone_wplug_bio_work() will release the

Re: [PATCH] blk-zoned: Document disk_zone_wplug_schedule_bio_work() locking

[Martin K. Petersen]

Bart,

> Document that all callers hold this lock because the code in
> disk_zone_wplug_schedule_bio_work() depends on this.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen

Re: [PATCH] blk-zoned: Document disk_zone_wplug_schedule_bio_work() locking

[Jens Axboe]

On 11/12/25 11:24 AM, Bart Van Assche wrote:
> Document that all callers hold this lock because the code in
> disk_zone_wplug_schedule_bio_work() depends on this.

This is already included in your previous series?

-- 
Jens Axboe

Re: [PATCH] blk-zoned: Document disk_zone_wplug_schedule_bio_work() locking

[Bart Van Assche]

On 11/13/25 6:22 AM, Jens Axboe wrote:
> On 11/12/25 11:24 AM, Bart Van Assche wrote:
>> Document that all callers hold this lock because the code in
>> disk_zone_wplug_schedule_bio_work() depends on this.
> 
> This is already included in your previous series?

Hi Jens,

You are right, this patch is already in the series "[PATCH v2 0/3] 
Refactor blk_zone_wplug_handle_write()" and is already in your for-next 
branch. Thanks for having reported this. Something went wrong at my side
(wrong branch?). I will check which SCSI patch I actually wanted to
send out and resend it.

Bart.