public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* Issue in sas_ex_discover_dev() for multiple level of SAS expanders in a domain
@ 2024-04-24  8:59 Li, Eric (Honggang)
  2024-04-24 10:46 ` John Garry
  0 siblings, 1 reply; 22+ messages in thread
From: Li, Eric (Honggang) @ 2024-04-24  8:59 UTC (permalink / raw)
  To: james.bottomley@hansenpartnership.com, Martin K . Petersen
  Cc: linux-scsi@vger.kernel.org

Hi,

There is an issue in the function sas_ex_discover_dev() when I have multiple SAS expanders chained under one SAS port on SAS controller.

In this function, we first check whether the PHY’s attached_sas_address is already present in the SAS domain, and then check if this PHY belongs to an existing port on this SAS expander.
I think this has an issue if this SAS expander use a wide port connecting a downstream SAS expander.
This is because if the PHY belongs to an existing port on this SAS expander, the attached SAS address of this port must already be present in the domain and it results in disabling that port.
I don’t think that is what we expect.

In old release (4.x), at the end of this function, it would make addition sas_ex_join_wide_port() call for any possibly PHYs that could be added into the SAS port.
This will make subsequent PHYs (other than the first PHY of that port) being marked to DISCOVERED so that this function would not be invoked on those subsequent PHYs (in that port).
But potential question here is we didn’t configure the per-PHY routing table for those PHYs.
As I don’t have such SAS expander on hand, I am not sure what’s impact (maybe just performance/bandwidth impact).
But at least, it didn’t impact the functionality of that port.

But in v5.3 or later release, that part of code was removed (in the commit a1b6fb947f923).
And this caused this problem occurred (downstream port of that SAS expander was disabled and all downstream SAS devices were removed from the domain).

Regards.
Eric Li

SPE, DellEMC
3/F KIC 1, 252# Songhu Road, YangPu District, SHANGHAI
+86-21-6036-4384


Internal Use - Confidential

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2025-06-10 14:43 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-24  8:59 Issue in sas_ex_discover_dev() for multiple level of SAS expanders in a domain Li, Eric (Honggang)
2024-04-24 10:46 ` John Garry
2024-04-25  2:57   ` Jason Yan
2024-04-25  5:03     ` Li, Eric (Honggang)
2024-04-30 14:22       ` Li, Eric (Honggang)
2024-05-01 14:23         ` John Garry
2024-05-03  3:15           ` Li, Eric (Honggang)
2024-05-03  8:33             ` John Garry
2024-05-06  1:49               ` Li, Eric (Honggang)
2024-05-07  8:03                 ` John Garry
2024-05-07  8:44                 ` Li, Eric (Honggang)
2024-05-07  9:17                   ` John Garry
2024-05-07 11:17                     ` Li, Eric (Honggang)
2024-05-07 15:14                       ` John Garry
2024-05-08  0:59                         ` Li, Eric (Honggang)
2024-05-08  7:48                           ` John Garry
2024-05-08  8:29                             ` Li, Eric (Honggang)
2024-05-09  3:52                               ` Jason Yan
2024-05-11  3:41                               ` Jason Yan
2024-05-14  9:23                                 ` Li, Eric (Honggang)
2025-06-10 13:05                                   ` Li, Eric (Honggang)
2025-06-10 13:33                                     ` Jason Yan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox