From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v3 5/7] scsi: ufs: Initialize hba->reserved_slot earlier
Date: Tue, 2 Jul 2024 06:25:26 +0000 [thread overview]
Message-ID: <c1c8bf50958118606dc0ce15e1f36732da54251e.camel@mediatek.com> (raw)
In-Reply-To: <20240701180419.1028844-6-bvanassche@acm.org>
On Mon, 2024-07-01 at 11:03 -0700, Bart Van Assche wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> Move the hba->reserved_slot and the host->can_queue assignments from
> ufshcd_config_mcq() into ufshcd_alloc_mcq(). The advantages of this
> change are as follows:
> - It becomes easier to verify that these two parameters are updated
> if hba->nutrs is updated.
> - It prevents unnecessary assignments to these two parameters. While
> ufshcd_config_mcq() is called during host reset, ufshcd_alloc_mcq()
> is not.
>
> Cc: Can Guo <quic_cang@quicinc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2024-07-02 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 18:03 [PATCH v3 0/7] UFS patches for kernel 6.11 Bart Van Assche
2024-07-01 18:03 ` [PATCH v3 1/7] scsi: ufs: Declare functions once Bart Van Assche
2024-07-02 1:27 ` Keoseong Park
2024-07-02 6:22 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 2/7] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-02 6:23 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 3/7] scsi: ufs: Remove two constants Bart Van Assche
2024-07-02 6:23 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 4/7] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-02 6:24 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 5/7] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-02 6:25 ` Peter Wang (王信友) [this message]
2024-07-01 18:03 ` [PATCH v3 6/7] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-02 6:26 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 7/7] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-02 6:29 ` Peter Wang (王信友)
2024-07-02 20:27 ` Bart Van Assche
2024-07-03 8:53 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1c8bf50958118606dc0ce15e1f36732da54251e.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox