From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "quic_mnaresh@quicinc.com" <quic_mnaresh@quicinc.com>,
"akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"cw9316.lee@samsung.com" <cw9316.lee@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"daejun7.park@samsung.com" <daejun7.park@samsung.com>,
"yang.lee@linux.alibaba.com" <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH v3 7/7] scsi: ufs: Make .get_hba_mac() optional
Date: Wed, 3 Jul 2024 08:53:05 +0000 [thread overview]
Message-ID: <cfbe5681a2134bbd7e377932ac8c9a61d3f2fe61.camel@mediatek.com> (raw)
In-Reply-To: <31ba05cc-3ab0-465f-8d3c-b0e32e13f583@acm.org>
On Tue, 2024-07-02 at 13:27 -0700, Bart Van Assche wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
> On 7/1/24 11:29 PM, Peter Wang (王信友) wrote:
> > Before ufshcd_mcq_enable,
> > here read REG_CONTROLLER_CAPABILITIES should be SDB value.
> > Beacuse MCQ is not enable.
>
> I think this needs to be fixed in another way, namely by enabling MCQ
> before ufshcd_mcq_decide_queue_depth() is called. See also v3 of this
> patch series.
>
> Thanks,
>
> Bart.
>
Hi Bart,
Yes, enable mcq before ufshcd_mcq_decide_queue_depth is right.
Thanks.
Peter
prev parent reply other threads:[~2024-07-03 8:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 18:03 [PATCH v3 0/7] UFS patches for kernel 6.11 Bart Van Assche
2024-07-01 18:03 ` [PATCH v3 1/7] scsi: ufs: Declare functions once Bart Van Assche
2024-07-02 1:27 ` Keoseong Park
2024-07-02 6:22 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 2/7] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-02 6:23 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 3/7] scsi: ufs: Remove two constants Bart Van Assche
2024-07-02 6:23 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 4/7] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-02 6:24 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 5/7] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-02 6:25 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 6/7] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-02 6:26 ` Peter Wang (王信友)
2024-07-01 18:03 ` [PATCH v3 7/7] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-02 6:29 ` Peter Wang (王信友)
2024-07-02 20:27 ` Bart Van Assche
2024-07-03 8:53 ` Peter Wang (王信友) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfbe5681a2134bbd7e377932ac8c9a61d3f2fe61.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akinobu.mita@gmail.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cw9316.lee@samsung.com \
--cc=daejun7.park@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=quic_mnaresh@quicinc.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox