From: Bart Van Assche <bvanassche@acm.org>
To: Himanshu Madhani <hmadhani@marvell.com>
Cc: "<James.Bottomley@hansenpartnership.com>"
<James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 4/8] qla2xxx: Fix driver unload hang
Date: Thu, 7 Nov 2019 10:30:34 -0800 [thread overview]
Message-ID: <cff0bb9a-4495-1064-dffc-5a15dcb30dbd@acm.org> (raw)
In-Reply-To: <10b38f34-128a-fd71-1542-9025dc107f62@acm.org>
On 11/7/19 9:58 AM, Bart Van Assche wrote:
> Does your answer mean that this hang has not yet been root-caused fully
> and hence that it is possible this patch is only a workaround but not a
> fix of the root cause?
Answering my own question: I think that a qpair refcount leak is a
severe problem and not something that should be ignored. How about
changing the while loop into something like the following:
if (atomic_read(&qpair->ref_count))
msleep(500);
WARN_ON_ONCE(atomic_read(&qpair->ref_count));
Thanks,
Bart.
next prev parent reply other threads:[~2019-11-07 18:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 15:06 [PATCH 0/8] qla2xxx: Bug Fixes for the driver Himanshu Madhani
2019-11-05 15:06 ` [PATCH 1/8] qla2xxx: Retry PLOGI on FC-NVMe PRLI failure Himanshu Madhani
2019-11-05 15:18 ` Ewan D. Milne
2019-11-05 15:06 ` [PATCH 2/8] qla2xxx: Do command completion on abort timeout Himanshu Madhani
2019-11-05 15:18 ` Ewan D. Milne
2019-11-05 16:57 ` Bart Van Assche
2019-11-07 16:46 ` [EXT] " Himanshu Madhani
2019-11-05 15:06 ` [PATCH 3/8] qla2xxx: Fix SRB leak on switch command timeout Himanshu Madhani
2019-11-05 15:19 ` Ewan D. Milne
2019-11-05 15:06 ` [PATCH 4/8] qla2xxx: Fix driver unload hang Himanshu Madhani
2019-11-05 15:19 ` Ewan D. Milne
2019-11-07 16:54 ` Bart Van Assche
[not found] ` <83CC0DDF-4907-41A2-91EC-1569A07A6BA9@marvell.com>
2019-11-07 17:58 ` Bart Van Assche
2019-11-07 18:30 ` Bart Van Assche [this message]
2019-11-08 23:38 ` [EXT] " Himanshu Madhani
2019-11-08 23:58 ` Bart Van Assche
2019-11-05 15:06 ` [PATCH 5/8] qla2xxx: Fix double scsi_done for abort path Himanshu Madhani
2019-11-05 15:20 ` Ewan D. Milne
2019-11-07 18:01 ` Bart Van Assche
2019-11-05 15:06 ` [PATCH 6/8] qla2xxx: Fix memory leak when sending I/O fails Himanshu Madhani
2019-11-05 15:20 ` Ewan D. Milne
2019-11-18 20:25 ` Himanshu Madhani
2019-11-19 5:02 ` Martin K. Petersen
2019-11-05 15:06 ` [PATCH 7/8] qla2xxx: Fix device connect issues in P2P configuration Himanshu Madhani
2019-11-05 15:21 ` Ewan D. Milne
2019-11-05 15:06 ` [PATCH 8/8] qla2xxx: Update driver version to 10.01.00.21-k Himanshu Madhani
2019-11-05 15:21 ` Ewan D. Milne
2019-11-09 2:16 ` [PATCH 0/8] qla2xxx: Bug Fixes for the driver Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff0bb9a-4495-1064-dffc-5a15dcb30dbd@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hmadhani@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox