Re: [PATCH] UFS: Make TM command timeout configurable from host side

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Wed, 2025-11-12 at 17:49 +0900, Seunghui Lee wrote:
> 
> Hi Peter,
> 
> Currently, the modification is about changing it in the same way as
> nop_out_timeout.
> The tm_cmd_timeout value is not read from the device.
> Also, if the UFS can read the tm_cmd_timeout value and requires a
> longer timeout period than the specified value, dev quirks would also
> be acceptable.
> 
> However, for now, it seems fine to set it on the host.
> When we checked on our side, it wasn't that the tm timeout value was
> insufficient for specific devices, but rather some vendors needed to
> increase it.
> We plan to appropriately increase and use it. Also, since the current
> modification maintains the default value and allows an appropriate
> value to be adjusted according to each vendor, the current method
> also seems acceptable.
> 
> Thank you,
> Seunghui Lee.
> 

Hi Seunghui,

The nop_out_timeout value can be changed by the host, as shown here:
https://lore.kernel.org/all/20210831145317.26306-1-adrian.hunter@intel.com/
(hba->nop_out_timeout = 200;)

However, in this patch, no one sets tm_cmd_timeout, correct?
So, I am saying that this patch doesn’t actually change anything, 
because the timeout is still 100ms for all hosts.

Thanks
Peter