[PATCH v1 0/1] Add code for ufs suspend error.

[PATCH v1 0/1] Add code for ufs suspend error.

[Seunghwan Baek]

Add ufshcd_update_evt_hist to record ufs suspend error event history.

Seunghwan Baek (1):
  scsi: ufs : core: Add ufshcd_update_evt_hist for ufs suspend error.

 drivers/ufs/core/ufshcd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.43.0

[PATCH v1 1/1] scsi: ufs : core: Add ufshcd_update_evt_hist for ufs suspend error.

[Seunghwan Baek]

If the ufs resume fails, the event history is updated in ufshcd_resume,
but there is no code anywhere to record ufs suspend. Therefore, add code
to record ufs suspend error event history.

Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
Cc: stable@vger.kernel.org

Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>
---
 drivers/ufs/core/ufshcd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 040a0ceb170a..6bb2781aefc7 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -10337,7 +10337,7 @@ static int ufshcd_suspend(struct ufs_hba *hba)
 	ret = ufshcd_setup_clocks(hba, false);
 	if (ret) {
 		ufshcd_enable_irq(hba);
-		return ret;
+		goto out;
 	}
 	if (ufshcd_is_clkgating_allowed(hba)) {
 		hba->clk_gating.state = CLKS_OFF;
@@ -10349,6 +10349,9 @@ static int ufshcd_suspend(struct ufs_hba *hba)
 	/* Put the host controller in low power mode if possible */
 	ufshcd_hba_vreg_set_lpm(hba);
 	ufshcd_pm_qos_update(hba, false);
+out:
+	if (ret)
+		ufshcd_update_evt_hist(hba, UFS_EVT_SUSPEND_ERR, (u32)ret);
 	return ret;
 }
 
-- 
2.43.0

Re: [PATCH v1 1/1] scsi: ufs : core: Add ufshcd_update_evt_hist for ufs suspend error.

[Peter Wang (王信友)]

On Wed, 2025-12-10 at 15:38 +0900, Seunghwan Baek wrote:
> If the ufs resume fails, the event history is updated in
> ufshcd_resume,
> but there is no code anywhere to record ufs suspend. Therefore, add
> code
> to record ufs suspend error event history.
> 
> Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs
> directory")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>

Reviewed-by: Peter Wang <peter.wang@mediatek.com>

Re: [PATCH v1 1/1] scsi: ufs : core: Add ufshcd_update_evt_hist for ufs suspend error.

[Martin K. Petersen]

On Wed, 10 Dec 2025 15:38:54 +0900, Seunghwan Baek wrote:

> If the ufs resume fails, the event history is updated in ufshcd_resume,
> but there is no code anywhere to record ufs suspend. Therefore, add code
> to record ufs suspend error event history.
> 
> Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
> Cc: stable@vger.kernel.org
> 
> [...]

Applied to 6.19/scsi-fixes, thanks!

[1/1] scsi: ufs : core: Add ufshcd_update_evt_hist for ufs suspend error.
      https://git.kernel.org/mkp/scsi/c/c9f36f04a8a2

-- 
Martin K. Petersen