Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v5 00/28] Optimize the hot path in the UFS driver
Date: Fri, 26 Sep 2025 11:08:40 +0100	[thread overview]
Message-ID: <dab3464e-7f60-4843-aede-6c81a348da8a@oracle.com> (raw)
In-Reply-To: <20250924203142.4073403-1-bvanassche@acm.org>

Did you notice this when you tested?

[    0.927347]   dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
[    0.930065] ------------[ cut here ]------------
[    0.931137] WARNING: CPU: 1 PID: 1 at drivers/scsi/scsi_scan.c:228
scsi_realloc_sdev_budget_map+0x163/0x180
[    0.933292] Modules linked in:
[    0.933948] CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted
6.17.0-rc1-00143-g67ede8ca8ab5-dirty #1769 PREEMPT(voluntary)
[    0.936317] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009),
BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014
[    0.938683] RIP: 0010:scsi_realloc_sdev_budget_map+0x163/0x180
[    0.939955] Code: 45 39 ee 44 89 ee 48 8b 7c 24 28 41 0f 46 f6 e8
23 df be ff 48 8b 7c 24 08 e8 f9 99 85 ff 48 8b 3c 24 e8 90 ed 8a ff
eb ae 90 <0f> 0b 90 48 83 c4 30 b8 ea ff ff ff 5b 5d 41 5c 41 5d 41 5e
41 5f
[    0.943854] RSP: 0000:ffffb29bc00139c8 EFLAGS: 00010246
[    0.944950] RAX: 0000000000000080 RBX: ffff89bac0a53800 RCX: 
0000000000000005
[    0.946515] RDX: 0000000000000003 RSI: 0000000000000004 RDI: 
ffff89bac0a53800
[    0.948019] RBP: ffff89bac0a4e000 R08: 0000000000000000 R09: 
0000000000000001
[    0.949521] R10: 0000000000000000 R11: 0000000000000008 R12: 
00000000000000c0
[    0.951038] R13: 00000000000000c0 R14: ffff89bac3d09828 R15: 
0000000000000005
[    0.952537] FS:  0000000000000000(0000) GS:ffff89bb47fe3000(0000)
knlGS:0000000000000000
[    0.954258] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.955464] CR2: 0000000000000000 CR3: 0000000120e30001 CR4: 
0000000000370ef0
[    0.957001] Call Trace:
[    0.957547]  <TASK>
[    0.958087]  ? attribute_container_add_device+0x4b/0x130
[    0.959295]  scsi_alloc_sdev+0x27f/0x360
[    0.960191]  scsi_probe_and_add_lun+0x1e4/0x2f0
[    0.961203]  __scsi_scan_target+0x104/0x210
[    0.962157]  scsi_scan_channel+0x54/0x90
[    0.962942]  scsi_scan_host_selected+0xcf/0x100
[    0.964420]  scsi_scan_host+0x19f/0x1c0
[    0.965289]  sdebug_driver_probe+0x1c0/0x420
[    0.966317]  really_probe+0xba/0x2b0
[    0.967171]  ? __pfx___device_attach_driver+0x10/0x10
[    0.968308]  __driver_probe_device+0x6e/0x110
[    0.969286]  driver_probe_device+0x1a/0xe0
[    0.970232]  __device_attach_driver+0x7e/0x110
[    0.971276]  bus_for_each_drv+0x8f/0xe0
[    0.972183]  __device_attach+0xa9/0x1a0
[    0.973080]  bus_probe_device+0x88/0xa0
[    0.973973]  device_add+0x61c/0x810
[    0.974805]  sdebug_add_host_helper+0x1ca/0x260
[    0.975843]  scsi_debug_init+0x341/0x7d0
[    0.976770]  ? __pfx_scsi_debug_init+0x10/0x10
[    0.977801]  do_one_initcall+0x55/0x220
[    0.978706]  kernel_init_freeable+0x199/0x2e0
[    0.979744]  ? __pfx_kernel_init+0x10/0x10
[    0.980688]  kernel_init+0x15/0x1c0
[    0.981765]  ret_from_fork+0x80/0xd0
[    0.982710]  ? __pfx_kernel_init+0x10/0x10
[    0.983689]  ret_from_fork_asm+0x1a/0x30
[    0.984742]  </TASK>
[    0.985223] ---[ end trace 0000000000000000 ]---
[    0.986231] scsi_alloc_sdev: Allocation failure during SCSI
scanning, some SCSI devices might not be configured

  parent reply	other threads:[~2025-09-26 10:08 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 20:30 [PATCH v5 00/28] Optimize the hot path in the UFS driver Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 01/28] scsi: core: Support allocating reserved commands Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 02/28] scsi: core: Move two statements Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 03/28] scsi: core: Make the budget map optional Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 04/28] scsi: core: Support allocating a pseudo SCSI device Bart Van Assche
2025-09-26  7:14   ` John Garry
2025-09-26 20:01     ` Bart Van Assche
2025-09-26 22:21   ` Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 05/28] scsi: core: Introduce .queue_reserved_command() Bart Van Assche
2025-09-26  7:24   ` John Garry
2025-09-26 20:05     ` Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 06/28] scsi: core: Add scsi_{get,put}_internal_cmd() helpers Bart Van Assche
2025-09-25 16:38   ` John Garry
2025-09-24 20:30 ` [PATCH v5 07/28] scsi_debug: Abort SCSI commands via .queue_reserved_command() Bart Van Assche
2025-09-26  7:32   ` John Garry
2025-09-26 20:44     ` Bart Van Assche
2025-09-30  7:03       ` John Garry
2025-10-01 18:26         ` Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 08/28] ufs: core: Move an assignment in ufshcd_mcq_process_cqe() Bart Van Assche
2025-09-26  6:12   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 09/28] ufs: core: Change the type of one ufshcd_add_cmd_upiu_trace() argument Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 10/28] ufs: core: Only call ufshcd_add_command_trace() for SCSI commands Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 11/28] ufs: core: Change the type of one ufshcd_add_command_trace() argument Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 12/28] ufs: core: Change the type of one ufshcd_send_command() argument Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 13/28] ufs: core: Only call ufshcd_should_inform_monitor() for SCSI commands Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 14/28] ufs: core: Change the monitor function argument types Bart Van Assche
2025-09-26  6:24   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 15/28] ufs: core: Rework ufshcd_mcq_compl_pending_transfer() Bart Van Assche
2025-09-26  6:44   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 16/28] ufs: core: Rework ufshcd_eh_device_reset_handler() Bart Van Assche
2025-09-26  7:17   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 17/28] ufs: core: Rework the SCSI host queue depth calculation code Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 18/28] ufs: core: Allocate the SCSI host earlier Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 19/28] ufs: core: Call ufshcd_init_lrb() later Bart Van Assche
2025-09-27  9:39   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 20/28] ufs: core: Use hba->reserved_slot Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 21/28] ufs: core: Make the reserved slot a reserved request Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 22/28] ufs: core: Do not clear driver-private command data Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 23/28] ufs: core: Optimize the hot path Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 24/28] ufs: core: Pass a SCSI pointer instead of an LRB pointer Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 25/28] ufs: core: Remove the ufshcd_lrb task_tag member Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 26/28] ufs: core: Make blk_mq_tagset_busy_iter() skip reserved requests Bart Van Assche
2025-09-24 20:30 ` [PATCH v5 27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd() Bart Van Assche
2025-09-27  9:11   ` Avri Altman
2025-09-24 20:30 ` [PATCH v5 28/28] ufs: core: Switch to scsi_get_internal_cmd() Bart Van Assche
2025-09-26 10:08 ` John Garry [this message]
2025-09-26 17:32   ` [PATCH v5 00/28] Optimize the hot path in the UFS driver Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dab3464e-7f60-4843-aede-6c81a348da8a@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox