Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	Avri Altman <avri.altman@wdc.com>,
	linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Bean Huo <beanhuo@micron.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Jinyoung Choi <j-young.choi@samsung.com>
Subject: Re: [PATCH 3/3] scsi: ufs: Enable DMA clustering
Date: Thu, 12 Jan 2023 15:12:06 -0800	[thread overview]
Message-ID: <ddea8484-76fa-d2cb-5dde-51a343b9be66@acm.org> (raw)
In-Reply-To: <56f36c02-bc04-0587-2980-d28b7b75394f@intel.com>

On 1/9/23 23:56, Adrian Hunter wrote:
> On 6/01/23 23:58, Bart Van Assche wrote:
>> All UFS host controllers support DMA clustering. Hence enable DMA
>> clustering.
> 
> The patch history of ufshcd.c seems to suggest the dma_boundary
> setting was never intentional, but was inherited by default.
> 
> However, I guess it is not impossible that removing the setting
> exposes issues for existing controllers.
> 
> I suggest perhaps expanding upon the commit message and the
> cc list so more people will be aware of the change.
> 
> Possibly worth including the explanation in your reply to
> Avri concerning PRDT 256K DBC limit
> 
>>
>> Note: without patch "Exynos: Fix the maximum segment size", this patch
>> breaks support for the Exynos controller.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> 
> Otherwise:
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Hi Adrian,

I will make the requested changes.

Thanks for the review!

Bart.


      reply	other threads:[~2023-01-12 23:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 21:57 [PATCH 0/3] Enable DMA clustering in the UFS driver Bart Van Assche
2023-01-06 21:57 ` [PATCH 1/3] scsi: ufs: Exynos: Fix DMA alignment for PAGE_SIZE != 4096 Bart Van Assche
2023-01-11  6:20   ` Alim Akhtar
2023-01-06 21:57 ` [PATCH 2/3] scsi: ufs: Exynos: Fix the maximum segment size Bart Van Assche
2023-01-11  6:21   ` Alim Akhtar
2023-01-12 22:37     ` Bart Van Assche
2023-01-06 21:58 ` [PATCH 3/3] scsi: ufs: Enable DMA clustering Bart Van Assche
2023-01-08  8:20   ` Avri Altman
2023-01-08 22:44     ` Bart Van Assche
2023-01-10  7:56   ` Adrian Hunter
2023-01-12 23:12     ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddea8484-76fa-d2cb-5dde-51a343b9be66@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=j-young.choi@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox