[PATCH v2] scsi: aacraid: Improve code readability

[PATCH v2] scsi: aacraid: Improve code readability

[Bart Van Assche]

aac_queuecommand() is a scsi_host_template.queuecommand() implementation.
Any value returned by this function other than one of the following values
is translated into SCSI_MLQUEUE_HOST_BUSY:
* 0
* SCSI_MLQUEUE_HOST_BUSY
* SCSI_MLQUEUE_DEVICE_BUSY
* SCSI_MLQUEUE_EH_RETRY
* SCSI_MLQUEUE_TARGET_BUSY

Improve readability of aac_queuecommand() by returning
SCSI_MLQUEUE_HOST_BUSY instead of FAILED.

Cc: Gilbert Wu <gilbert.wu@microchip.com>
Cc: Sagar Biradar <Sagar.Biradar@microchip.com>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---

Changes compared to v1: instead of failing a SCSI command if aac_scsi_cmd()
  returns a value that is not zero, let the SCSI core retry the command.

 drivers/scsi/aacraid/linit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index ea66196ef7c7..82c6e7c7cdaf 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -242,7 +242,7 @@ static int aac_queuecommand(struct Scsi_Host *shost,
 {
 	aac_priv(cmd)->owner = AAC_OWNER_LOWLEVEL;
 
-	return aac_scsi_cmd(cmd) ? FAILED : 0;
+	return aac_scsi_cmd(cmd) ? SCSI_MLQUEUE_HOST_BUSY : 0;
 }
 
 /**

Re: [PATCH v2] scsi: aacraid: Improve code readability

[John Garry]

On 21/10/2025 21:17, Bart Van Assche wrote:
> aac_queuecommand() is a scsi_host_template.queuecommand() implementation.
> Any value returned by this function other than one of the following values
> is translated into SCSI_MLQUEUE_HOST_BUSY:
> * 0
> * SCSI_MLQUEUE_HOST_BUSY
> * SCSI_MLQUEUE_DEVICE_BUSY
> * SCSI_MLQUEUE_EH_RETRY
> * SCSI_MLQUEUE_TARGET_BUSY
> 
> Improve readability of aac_queuecommand() by returning
> SCSI_MLQUEUE_HOST_BUSY instead of FAILED.
> 
> Cc: Gilbert Wu <gilbert.wu@microchip.com>
> Cc: Sagar Biradar <Sagar.Biradar@microchip.com>
> Cc: John Garry <john.g.garry@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
> 
> Changes compared to v1: instead of failing a SCSI command if aac_scsi_cmd()
>    returns a value that is not zero, let the SCSI core retry the command.
> 
>   drivers/scsi/aacraid/linit.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index ea66196ef7c7..82c6e7c7cdaf 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -242,7 +242,7 @@ static int aac_queuecommand(struct Scsi_Host *shost,
>   {
>   	aac_priv(cmd)->owner = AAC_OWNER_LOWLEVEL;
>   
> -	return aac_scsi_cmd(cmd) ? FAILED : 0;
> +	return aac_scsi_cmd(cmd) ? SCSI_MLQUEUE_HOST_BUSY : 0;
>   }
>   
>   /**

Re: [PATCH v2] scsi: aacraid: Improve code readability

[Martin K. Petersen]

Bart,

> aac_queuecommand() is a scsi_host_template.queuecommand()
> implementation. Any value returned by this function other than one of
> the following values is translated into SCSI_MLQUEUE_HOST_BUSY:

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen

Re: [PATCH v2] scsi: aacraid: Improve code readability

[Martin K. Petersen]

On Tue, 21 Oct 2025 13:17:43 -0700, Bart Van Assche wrote:

> aac_queuecommand() is a scsi_host_template.queuecommand() implementation.
> Any value returned by this function other than one of the following values
> is translated into SCSI_MLQUEUE_HOST_BUSY:
> * 0
> * SCSI_MLQUEUE_HOST_BUSY
> * SCSI_MLQUEUE_DEVICE_BUSY
> * SCSI_MLQUEUE_EH_RETRY
> * SCSI_MLQUEUE_TARGET_BUSY
> 
> [...]

Applied to 6.19/scsi-queue, thanks!

[1/1] scsi: aacraid: Improve code readability
      https://git.kernel.org/mkp/scsi/c/e414748b7e83

-- 
Martin K. Petersen