From: Mike Christie <michael.christie@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Lee Duncan <lduncan@suse.com>, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>,
John Garry <john.garry@huawei.com>,
Hannes Reinecke <hare@suse.de>, Jonathan Corbet <corbet@lwn.net>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Chris Leech <cleech@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Khazhismel Kumykov <khazhy@google.com>
Subject: Re: [PATCH v4 02/10] scsi: core: Change the return type of .eh_timed_out()
Date: Thu, 20 Oct 2022 12:22:50 -0500 [thread overview]
Message-ID: <f3b930bf-4d7b-6806-0323-b6b2a275a4e9@oracle.com> (raw)
In-Reply-To: <20221018202958.1902564-3-bvanassche@acm.org>
On 10/18/22 3:29 PM, Bart Van Assche wrote:
> Commit 6600593cbd93 ("block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE")
> made it impossible for .eh_timed_out() implementations to call
> scsi_done() without causing a crash. Restore support for SCSI timeout
> handlers to call scsi_done() as follows:
> * Change all .eh_timed_out() handlers as follows:
> - Change the return type into enum scsi_timeout_action.
> - Change BLK_EH_RESET_TIMER into SCSI_EH_RESET_TIMER.
> - Change BLK_EH_DONE into SCSI_EH_NOT_HANDLED.
> * In scsi_timeout(), convert the SCSI_EH_* values into BLK_EH_* values.
Reviewed-by: Mike Christie <michael.christie@oracle.com>
next prev parent reply other threads:[~2022-10-20 17:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 20:29 [PATCH v4 00/10] Fix a deadlock in the UFS driver Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 01/10] scsi: core: Fix a race between scsi_done() and scsi_timeout() Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 02/10] scsi: core: Change the return type of .eh_timed_out() Bart Van Assche
2022-10-20 17:22 ` Mike Christie [this message]
2022-10-18 20:29 ` [PATCH v4 03/10] scsi: core: Support failing requests while recovering Bart Van Assche
2022-10-19 19:52 ` Mike Christie
2022-10-19 21:11 ` Bart Van Assche
2022-10-20 17:20 ` Mike Christie
2022-10-18 20:29 ` [PATCH v4 04/10] scsi: ufs: Remove an outdated comment Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 05/10] scsi: ufs: Use 'else' in ufshcd_set_dev_pwr_mode() Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 06/10] scsi: ufs: Reduce the START STOP UNIT timeout Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 07/10] scsi: ufs: Try harder to change the power mode Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 08/10] scsi: ufs: Track system suspend / resume activity Bart Van Assche
2022-10-18 20:29 ` [PATCH v4 09/10] scsi: ufs: Introduce the function ufshcd_execute_start_stop() Bart Van Assche
2022-10-19 19:57 ` Mike Christie
2022-10-19 21:13 ` Bart Van Assche
2022-10-20 17:21 ` Mike Christie
2022-10-18 20:29 ` [PATCH v4 10/10] scsi: ufs: Fix a deadlock between PM and the SCSI error handler Bart Van Assche
2022-10-22 3:27 ` [PATCH v4 00/10] Fix a deadlock in the UFS driver Martin K. Petersen
2022-10-23 6:16 ` Avri Altman
2022-10-24 23:27 ` Bart Van Assche
2022-10-27 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b930bf-4d7b-6806-0323-b6b2a275a4e9@oracle.com \
--to=michael.christie@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cleech@redhat.com \
--cc=corbet@lwn.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=khazhy@google.com \
--cc=kys@microsoft.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mrangankar@marvell.com \
--cc=mst@redhat.com \
--cc=njavali@marvell.com \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sthemmin@microsoft.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox