Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shivasharan S" <shivasharan.srikanteshwara@broadcom.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 31/37] scsi: mpt3sas: Restrict ioc_dump debugfs and replace raw ioc dump with text
Date: Wed, 18 Nov 2026 10:38:29 +0000	[thread overview]
Message-ID: <sashiko-outbox-220721@kernel.org> (raw)
In-Reply-To: <1794995806-5835-32-git-send-email-shivasharan.srikanteshwara@broadcom.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] scsi: mpt3sas: missing Fixes trailer for ioc_dump debugfs fix
- [Low] scsi: mpt3sas: inaccurate leak fix claim in
  _debugfs_iocdump_release()
--

commit 820d81c18cf70e4f505e1114ea0578843ea87567
Author: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>

> scsi: mpt3sas: Restrict ioc_dump debugfs and replace raw ioc dump with text
>
> The ioc_dump debugfs file previously exposed raw MPT3SAS_ADAPTER bytes,
> leaking kernel addresses, and was world-readable.
>
> Create the file with mode 0400 instead of 0444, replace the raw dump
> with a small human-readable text summary of key adapter properties, and
> fix the memory leak in the release path.
>
> Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
> Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>

[Severity: Low]
Since this fixes the raw adapter structure exposure and world-readable
debugfs permissions introduced in 2b01b293f359 ("scsi: mpt3sas: Capture IOC
data for debugging purposes"), should the commit message include:

  Fixes: 2b01b293f359 ("scsi: mpt3sas: Capture IOC data for debugging purposes")

> diff --git a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
> index 183391f6b8d19..432e120ac81db 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
> @@ -49,22 +49,62 @@ _debugfs_iocdump_read(struct file *filp, char __user *ubuf, size_t cnt,
>  	return simple_read_from_buffer(ubuf, cnt, ppos, debug->buf, debug->len);
>  }
>  
> +/* Buffer size for the text dump */
> +#define MPT3SAS_IOCDUMP_BUF_SZ 1024
> +
>  /*
> - * _debugfs_iocdump_open :	open the ioc_dump debugfs attribute file
> + * _debugfs_iocdump_open: open the ioc_dump debugfs attribute file.
> + * Populates the debugfs buffer with a summary of key adapter properties.
>   */
>  static int
>  _debugfs_iocdump_open(struct inode *inode, struct file *file)
>  {
>  	struct MPT3SAS_ADAPTER *ioc = inode->i_private;
>  	struct mpt3sas_debugfs_buffer *debug;
> +	char *buf;
> +	size_t len = 0;
>  
>  	debug = kzalloc_obj(struct mpt3sas_debugfs_buffer);
>  	if (!debug)
>  		return -ENOMEM;
>  
> -	debug->buf = (void *)ioc;
> -	debug->len = sizeof(struct MPT3SAS_ADAPTER);
> +	buf = kzalloc(MPT3SAS_IOCDUMP_BUF_SZ, GFP_KERNEL);
> +	if (!buf) {
> +		kfree(debug);
> +		return -ENOMEM;
> +	}

[ ... ]

> +	debug->buf = buf;
> +	debug->len = len;
>  	file->private_data = debug;
> +
>  	return 0;
>  }
>  
> @@ -82,6 +122,7 @@ _debugfs_iocdump_release(struct inode *inode, struct file *file)
>  		return 0;
>  
>  	file->private_data = NULL;
> +	kfree(debug->buf);
>  	kfree(debug);
>  	return 0;
>  }

[Severity: Low]
Is the commit message accurate when it says this fixes a memory leak in the
release path?

Previously _debugfs_iocdump_open() set debug->buf = (void *)ioc and only
allocated struct mpt3sas_debugfs_buffer, which _debugfs_iocdump_release()
freed with kfree(debug).  kfree(debug->buf) frees the text buffer newly
allocated by this patch in _debugfs_iocdump_open() rather than fixing an
existing leak.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/1794995806-5835-1-git-send-email-shivasharan.srikanteshwara@broadcom.com?part=31

  reply	other threads:[~2026-11-18 10:38 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:56 [PATCH v2 00/37] scsi: mpt3sas: Validate firmware/user input and fix error-path bugs Shivasharan S
2026-11-18  9:56 ` [PATCH v2 01/37] scsi: mpt3sas: Validate firmware-reported IOCRequestFrameSize Shivasharan S
2026-11-18 10:28   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 02/37] scsi: mpt3sas: Validate RAID configuration page length Shivasharan S
2026-11-18 10:22   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 03/37] scsi: mpt3sas: Pin Scsi_Host while an ioctl is using its ioc Shivasharan S
2026-11-18 10:41   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 04/37] scsi: mpt3sas: Fix locking and bounds checks on host_trace_buffer sysfs files Shivasharan S
2026-11-18 10:37   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 05/37] scsi: mpt3sas: Fix unlocked use of raid_device in enable_sdev_max_qd_store Shivasharan S
2026-11-18 10:36   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 06/37] scsi: mpt3sas: Fix invalid kfree() of fw_event_work event_data Shivasharan S
2026-11-18 10:30   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 07/37] scsi: mpt3sas: Validate SMP request/response length in bsg handler Shivasharan S
2026-11-18 10:29   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 08/37] scsi: mpt3sas: Validate firmware/user supplied device handles against MaxDevHandle Shivasharan S
2026-11-18 10:33   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 09/37] scsi: mpt3sas: Clamp topology/IR event entry counts to EventDataLength Shivasharan S
2026-11-18  9:56 ` [PATCH v2 10/37] scsi: mpt3sas: NULL ioc->reply_post after freeing it Shivasharan S
2026-11-18 10:27   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 11/37] scsi: mpt3sas: Fix port_table memory leak in _scsih_sas_port_refresh Shivasharan S
2026-11-18 10:22   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 12/37] scsi: mpt3sas: Fix leak and dangling pointer for io_uring_poll_queues Shivasharan S
2026-11-18 10:32   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 13/37] scsi: mpt3sas: Validate max_data_size in MPT3EVENTREPORT ioctl Shivasharan S
2026-11-18 10:20   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 14/37] scsi: mpt3sas: Fix buffer overflow in _scsih_scsi_ioc_info Shivasharan S
2026-11-18 10:21   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 15/37] scsi: mpt3sas: Fix Scsi_Host leak on invalid/tampered device probe Shivasharan S
2026-11-18 10:26   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 16/37] scsi: mpt3sas: Fix page fault from stale ioc->chip after PCI error recovery Shivasharan S
2026-11-18 11:01   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 17/37] scsi: mpt3sas: Clamp ValidEntries in driver trigger page update helpers Shivasharan S
2026-11-18 10:29   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 18/37] scsi: mpt3sas: Clamp firmware reply copies to the allocated reply buffer Shivasharan S
2026-11-18 10:29   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 19/37] scsi: mpt3sas: Reject implausibly small MaxReplyDescriptorPostQueueDepth Shivasharan S
2026-11-18 10:33   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 20/37] scsi: mpt3sas: Validate CurrentHostPageSize before using it as a shift amount Shivasharan S
2026-11-18 10:33   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 21/37] scsi: mpt3sas: Clamp sense_length before copying into transfer_packet->sense Shivasharan S
2026-11-18 10:35   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 22/37] scsi: mpt3sas: Clamp num_luns in _scsih_wait_for_target_to_become_ready Shivasharan S
2026-11-18 10:32   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 23/37] scsi: mpt3sas: Validate phy_number in mpt3sas_transport_update_links Shivasharan S
2026-11-18 10:42   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 24/37] scsi: mpt3sas: Require CAP_SYS_RAWIO for mpt2ctl/mpt3ctl ioctls Shivasharan S
2026-11-18  9:56 ` [PATCH v2 25/37] scsi: mpt3sas: Fix SGE offset boundary check in _ctl_do_mpt_command Shivasharan S
2026-11-18 10:39   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 26/37] scsi: mpt3sas: Enforce minimum reply frame size and validate chain segment size Shivasharan S
2026-11-18 10:46   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 27/37] scsi: mpt3sas: Replace panic() with error return in hard_reset_handler Shivasharan S
2026-11-18  9:56 ` [PATCH v2 28/37] scsi: mpt3sas: Replace panic() calls with error returns in _config_request Shivasharan S
2026-11-18  9:56 ` [PATCH v2 29/37] scsi: mpt3sas: Bound event-log copy size against reply frame size Shivasharan S
2026-11-18 10:39   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 30/37] scsi: mpt3sas: Add _ctl_diag_buffer_reset() helper to clear diag buffer state Shivasharan S
2026-11-18  9:56 ` [PATCH v2 31/37] scsi: mpt3sas: Restrict ioc_dump debugfs and replace raw ioc dump with text Shivasharan S
2026-11-18 10:38   ` sashiko-bot [this message]
2026-11-18  9:56 ` [PATCH v2 32/37] scsi: mpt3sas: Fix out-of-bounds bit operation in _scsih_check_topo_delete_events Shivasharan S
2026-11-18 10:38   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 33/37] scsi: mpt3sas: Bound SMP passthrough buffer reads to actual buffer size Shivasharan S
2026-11-18 10:40   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 34/37] scsi: mpt3sas: Release sas_device reference on error in mpt3sas_transport_port_add Shivasharan S
2026-11-18 10:51   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 35/37] scsi: mpt3sas: NULL the event_log pointer after freeing it Shivasharan S
2026-11-18  9:56 ` [PATCH v2 36/37] scsi: mpt3sas: Bound NVMe passthrough transfer size against PRP buffer capacity Shivasharan S
2026-11-18 10:47   ` sashiko-bot
2026-11-18  9:56 ` [PATCH v2 37/37] scsi: mpt3sas: Update driver version to 59.100.00.00 Shivasharan S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220721@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox