From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] ieee1394: sbp2: lower block queue alignment requirement
Date: Sun, 14 Jan 2007 19:45:30 +0100 (CET) [thread overview]
Message-ID: <tkrat.37326df2d568d12d@s5r6.in-berlin.de> (raw)
The old setting seems to be copy & paste from usb-storage.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
I wonder, do we need this call to blk_queue_dma_alignment() at all?
Does the block layer perhaps provide sufficient alignment guarantees?
Index: linux/drivers/ieee1394/sbp2.c
===================================================================
--- linux.orig/drivers/ieee1394/sbp2.c 2007-01-14 18:40:08.000000000 +0100
+++ linux/drivers/ieee1394/sbp2.c 2007-01-14 19:30:42.000000000 +0100
@@ -2012,7 +2012,10 @@ static int sbp2scsi_slave_configure(stru
{
struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0];
- blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
+ /* Page table elements shall be octlet-aligned.
+ * Everything else can be quadlet-aligned. */
+ blk_queue_dma_alignment(sdev->request_queue, 7);
+
sdev->use_10_for_rw = 1;
if (sdev->type == TYPE_ROM)
--
Stefan Richter
-=====-=-=== ---= -===-
http://arcgraph.de/sr/
next reply other threads:[~2007-01-14 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 18:45 Stefan Richter [this message]
2007-01-14 19:19 ` [PATCH] ieee1394: sbp2: lower block queue alignment requirement James Bottomley
2007-01-14 20:14 ` Stefan Richter
2007-01-15 19:39 ` Kristian Høgsberg
2007-01-15 19:50 ` Mike Christie
2007-01-15 20:02 ` Stefan Richter
2007-01-15 21:24 ` James Bottomley
2007-01-25 21:35 ` Stefan Richter
2007-02-04 12:04 ` [PATCH] ieee1394: sbp2: remove unnecessary alignments of struct members Stefan Richter
2007-02-04 12:05 ` [PATCH] ieee1394: sbp2: enforce 32bit DMA mapping Stefan Richter
2007-02-04 16:06 ` David Moore
2007-02-04 19:25 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.37326df2d568d12d@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox