* [PATCH] [v2] scsi: scsi_debug: fix uninitialized variable use
@ 2025-02-25 9:56 Arnd Bergmann
2025-03-04 2:01 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-02-25 9:56 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen, John Meneghini,
Kai Mäkisara
Cc: Arnd Bergmann, Kai Mäkisara, Bart Van Assche, John Garry,
linux-scsi, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
It appears that a typo has made it into the newly added code
drivers/scsi/scsi_debug.c:3035:3: error: variable 'len' is uninitialized when used here [-Werror,-Wuninitialized]
3035 | len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
| ^~~
Replace the '+=' with the intended '=' here.
Fixes: 568354b24c7d ("scsi: scsi_debug: Add compression mode page for tapes")
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: use the correct 'Fixes' tag
---
drivers/scsi/scsi_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 722ee8c067ae..f3e9a63bbf02 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -3032,7 +3032,7 @@ static int resp_mode_sense(struct scsi_cmnd *scp,
case 0xf: /* Compression Mode Page (tape) */
if (!is_tape)
goto bad_pcode;
- len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
+ len = resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
offset += len;
break;
case 0x11: /* Partition Mode Page (tape) */
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [v2] scsi: scsi_debug: fix uninitialized variable use
2025-02-25 9:56 [PATCH] [v2] scsi: scsi_debug: fix uninitialized variable use Arnd Bergmann
@ 2025-03-04 2:01 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2025-03-04 2:01 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, John Meneghini,
Kai Mäkisara, Arnd Bergmann, Bart Van Assche, John Garry,
linux-scsi, linux-kernel
Arnd,
> It appears that a typo has made it into the newly added code
>
> drivers/scsi/scsi_debug.c:3035:3: error: variable 'len' is uninitialized when used here [-Werror,-Wuninitialized]
> 3035 | len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
> | ^~~
>
> Replace the '+=' with the intended '=' here.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-04 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 9:56 [PATCH] [v2] scsi: scsi_debug: fix uninitialized variable use Arnd Bergmann
2025-03-04 2:01 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox