* [PATCH] scsi: scsi_error: Add comments to scsi_check_sense()
@ 2025-02-28 3:17 Damien Le Moal
2025-03-04 2:16 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Damien Le Moal @ 2025-02-28 3:17 UTC (permalink / raw)
To: Martin K . Petersen, linux-scsi
Add a comment block describing the COMPLETED case with asc/ascq 0x55/0xa
to mention that it relates to command duration limits very special
policy 0xD command completion.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/scsi/scsi_error.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 815e7d63f3e2..d08ed65abfa6 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -711,6 +711,13 @@ enum scsi_disposition scsi_check_sense(struct scsi_cmnd *scmd)
return SUCCESS;
case COMPLETED:
+ /*
+ * A command using command duration limits (CDL) with a
+ * descriptor set with policy 0xD may be completed with success
+ * and the sense data DATA CURRENTLY UNAVAILABLE, indicating
+ * that the command was in fact aborted because it exceeded its
+ * duration limit. Never retry these commands.
+ */
if (sshdr.asc == 0x55 && sshdr.ascq == 0x0a) {
set_scsi_ml_byte(scmd, SCSIML_STAT_DL_TIMEOUT);
req->cmd_flags |= REQ_FAILFAST_DEV;
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: scsi_error: Add comments to scsi_check_sense()
2025-02-28 3:17 [PATCH] scsi: scsi_error: Add comments to scsi_check_sense() Damien Le Moal
@ 2025-03-04 2:16 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2025-03-04 2:16 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Martin K . Petersen, linux-scsi
Damien,
> Add a comment block describing the COMPLETED case with asc/ascq
> 0x55/0xa to mention that it relates to command duration limits very
> special policy 0xD command completion.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-04 2:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-28 3:17 [PATCH] scsi: scsi_error: Add comments to scsi_check_sense() Damien Le Moal
2025-03-04 2:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox