* [PATCH] mpt3sas: Fix a fw_event memory leak
@ 2025-07-23 15:30 Tomas Henzl
2025-07-24 4:09 ` Sathya Prakash Veerichetty
2025-07-25 1:07 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Tomas Henzl @ 2025-07-23 15:30 UTC (permalink / raw)
To: linux-scsi; +Cc: sathya.prakash, ranjan.kumar
In _mpt3sas_fw_work the fw_event reference is removed, it should
be also freed in all cases.
Fixes: 4318c7347847 ("scsi: mpt3sas: Handle NVMe PCIe device related events generated from firmware.")
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 508861e88d9f..0f900ddb3047 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -10790,8 +10790,7 @@ _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event)
break;
case MPI2_EVENT_PCIE_TOPOLOGY_CHANGE_LIST:
_scsih_pcie_topology_change_event(ioc, fw_event);
- ioc->current_event = NULL;
- return;
+ break;
}
out:
fw_event_work_put(fw_event);
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mpt3sas: Fix a fw_event memory leak
2025-07-23 15:30 [PATCH] mpt3sas: Fix a fw_event memory leak Tomas Henzl
@ 2025-07-24 4:09 ` Sathya Prakash Veerichetty
2025-07-25 1:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Sathya Prakash Veerichetty @ 2025-07-24 4:09 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi, ranjan.kumar
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
On Wed, Jul 23, 2025 at 9:30 AM Tomas Henzl <thenzl@redhat.com> wrote:
>
> In _mpt3sas_fw_work the fw_event reference is removed, it should
> be also freed in all cases.
>
> Fixes: 4318c7347847 ("scsi: mpt3sas: Handle NVMe PCIe device related events generated from firmware.")
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 508861e88d9f..0f900ddb3047 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -10790,8 +10790,7 @@ _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event)
> break;
> case MPI2_EVENT_PCIE_TOPOLOGY_CHANGE_LIST:
> _scsih_pcie_topology_change_event(ioc, fw_event);
> - ioc->current_event = NULL;
> - return;
> + break;
> }
> out:
> fw_event_work_put(fw_event);
> --
> 2.49.0
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4214 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mpt3sas: Fix a fw_event memory leak
2025-07-23 15:30 [PATCH] mpt3sas: Fix a fw_event memory leak Tomas Henzl
2025-07-24 4:09 ` Sathya Prakash Veerichetty
@ 2025-07-25 1:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-07-25 1:07 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi, sathya.prakash, ranjan.kumar
Tomas,
> In _mpt3sas_fw_work the fw_event reference is removed, it should be
> also freed in all cases.
Applied to 6.17/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-25 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 15:30 [PATCH] mpt3sas: Fix a fw_event memory leak Tomas Henzl
2025-07-24 4:09 ` Sathya Prakash Veerichetty
2025-07-25 1:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox