* [PATCH] scsi: fnic: Replace memset with eth_zero_addr
@ 2025-05-19 8:54 Chen Ni
2025-05-20 18:12 ` Karan Tilak Kumar (kartilak)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen Ni @ 2025-05-19 8:54 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, Chen Ni
Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/scsi/fnic/fip.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
index 6e7c0b00eb41..19395e2aee44 100644
--- a/drivers/scsi/fnic/fip.c
+++ b/drivers/scsi/fnic/fip.c
@@ -200,7 +200,7 @@ void fnic_fcoe_start_fcf_discovery(struct fnic *fnic)
return;
}
- memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
+ eth_zero_addr(iport->selected_fcf.fcf_mac);
pdisc_sol = (struct fip_discovery *) frame;
*pdisc_sol = (struct fip_discovery) {
@@ -588,12 +588,12 @@ void fnic_common_fip_cleanup(struct fnic *fnic)
if (!is_zero_ether_addr(iport->fpma))
vnic_dev_del_addr(fnic->vdev, iport->fpma);
- memset(iport->fpma, 0, ETH_ALEN);
+ eth_zero_addr(iport->fpma);
iport->fcid = 0;
iport->r_a_tov = 0;
iport->e_d_tov = 0;
- memset(fnic->iport.fcfmac, 0, ETH_ALEN);
- memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
+ eth_zero_addr(fnic->iport.fcfmac);
+ eth_zero_addr(iport->selected_fcf.fcf_mac);
iport->selected_fcf.fcf_priority = 0;
iport->selected_fcf.fka_adv_period = 0;
iport->selected_fcf.ka_disabled = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] scsi: fnic: Replace memset with eth_zero_addr
2025-05-19 8:54 [PATCH] scsi: fnic: Replace memset with eth_zero_addr Chen Ni
@ 2025-05-20 18:12 ` Karan Tilak Kumar (kartilak)
2025-05-21 1:28 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2025-05-20 18:12 UTC (permalink / raw)
To: Chen Ni, Satish Kharat (satishkh), Sesidhar Baddela (sebaddel),
James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
On Monday, May 19, 2025 1:55 AM, Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/scsi/fnic/fip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
> index 6e7c0b00eb41..19395e2aee44 100644
> --- a/drivers/scsi/fnic/fip.c
> +++ b/drivers/scsi/fnic/fip.c
> @@ -200,7 +200,7 @@ void fnic_fcoe_start_fcf_discovery(struct fnic *fnic)
> return;
> }
>
> - memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
> + eth_zero_addr(iport->selected_fcf.fcf_mac);
>
> pdisc_sol = (struct fip_discovery *) frame;
> *pdisc_sol = (struct fip_discovery) {
> @@ -588,12 +588,12 @@ void fnic_common_fip_cleanup(struct fnic *fnic)
> if (!is_zero_ether_addr(iport->fpma))
> vnic_dev_del_addr(fnic->vdev, iport->fpma);
>
> - memset(iport->fpma, 0, ETH_ALEN);
> + eth_zero_addr(iport->fpma);
> iport->fcid = 0;
> iport->r_a_tov = 0;
> iport->e_d_tov = 0;
> - memset(fnic->iport.fcfmac, 0, ETH_ALEN);
> - memset(iport->selected_fcf.fcf_mac, 0, ETH_ALEN);
> + eth_zero_addr(fnic->iport.fcfmac);
> + eth_zero_addr(iport->selected_fcf.fcf_mac);
> iport->selected_fcf.fcf_priority = 0;
> iport->selected_fcf.fka_adv_period = 0;
> iport->selected_fcf.ka_disabled = 0;
> --
> 2.25.1
>
>
Hi Chen,
Thanks for these changes.
They look good to me.
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: fnic: Replace memset with eth_zero_addr
2025-05-19 8:54 [PATCH] scsi: fnic: Replace memset with eth_zero_addr Chen Ni
2025-05-20 18:12 ` Karan Tilak Kumar (kartilak)
@ 2025-05-21 1:28 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-05-21 1:28 UTC (permalink / raw)
To: Chen Ni
Cc: satishkh, sebaddel, kartilak, James.Bottomley, martin.petersen,
linux-scsi, linux-kernel
Chen,
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
Applied to 6.16/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: Replace memset with eth_zero_addr
2025-05-19 8:54 [PATCH] scsi: fnic: Replace memset with eth_zero_addr Chen Ni
2025-05-20 18:12 ` Karan Tilak Kumar (kartilak)
2025-05-21 1:28 ` Martin K. Petersen
@ 2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-05-28 2:20 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, James.Bottomley, Chen Ni
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Mon, 19 May 2025 16:54:57 +0800, Chen Ni wrote:
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
>
>
Applied to 6.16/scsi-queue, thanks!
[1/1] scsi: fnic: Replace memset with eth_zero_addr
https://git.kernel.org/mkp/scsi/c/9000f663c511
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-28 2:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-19 8:54 [PATCH] scsi: fnic: Replace memset with eth_zero_addr Chen Ni
2025-05-20 18:12 ` Karan Tilak Kumar (kartilak)
2025-05-21 1:28 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox