* [PATCH] scsi: fnic: Remove unnecessary debug print
@ 2025-02-25 21:49 Karan Tilak Kumar
2025-03-04 3:05 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Karan Tilak Kumar @ 2025-02-25 21:49 UTC (permalink / raw)
To: sebaddel
Cc: arulponn, djhawar, gcboffa, mkai2, satishkh, aeasi, jejb,
martin.petersen, linux-scsi, linux-kernel, Karan Tilak Kumar,
Dan Carpenter
Remove unnecessary debug print from fdls_schedule_oxid_free_retry_work.
As suggested by Dan, this information is already present in
stack traces, and the kernel is not expected to fail small allocations.
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
---
drivers/scsi/fnic/fdls_disc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
index 11211c469583..d12caede8919 100644
--- a/drivers/scsi/fnic/fdls_disc.c
+++ b/drivers/scsi/fnic/fdls_disc.c
@@ -323,10 +323,6 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)
spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);
if (!reclaim_entry) {
- FNIC_FCS_DBG(KERN_WARNING, fnic->host, fnic->fnic_num,
- "Failed to allocate memory for reclaim struct for oxid idx: 0x%x\n",
- idx);
-
schedule_delayed_work(&oxid_pool->schedule_oxid_free_retry,
msecs_to_jiffies(SCHEDULE_OXID_FREE_RETRY_TIME));
spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: fnic: Remove unnecessary debug print
2025-02-25 21:49 [PATCH] scsi: fnic: Remove unnecessary debug print Karan Tilak Kumar
@ 2025-03-04 3:05 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-03-04 3:05 UTC (permalink / raw)
To: Karan Tilak Kumar
Cc: sebaddel, arulponn, djhawar, gcboffa, mkai2, satishkh, aeasi,
jejb, martin.petersen, linux-scsi, linux-kernel, Dan Carpenter
Karan,
> Remove unnecessary debug print from fdls_schedule_oxid_free_retry_work.
> As suggested by Dan, this information is already present in
> stack traces, and the kernel is not expected to fail small allocations.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: fnic: Remove unnecessary debug print
2025-02-25 21:49 [PATCH] scsi: fnic: Remove unnecessary debug print Karan Tilak Kumar
2025-03-04 3:05 ` Martin K. Petersen
@ 2025-03-11 1:19 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-03-11 1:19 UTC (permalink / raw)
To: sebaddel, Karan Tilak Kumar
Cc: Martin K . Petersen, arulponn, djhawar, gcboffa, mkai2, satishkh,
aeasi, jejb, linux-scsi, linux-kernel, Dan Carpenter
On Tue, 25 Feb 2025 13:49:09 -0800, Karan Tilak Kumar wrote:
> Remove unnecessary debug print from fdls_schedule_oxid_free_retry_work.
> As suggested by Dan, this information is already present in
> stack traces, and the kernel is not expected to fail small allocations.
>
>
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: fnic: Remove unnecessary debug print
https://git.kernel.org/mkp/scsi/c/9b2d1ecf8797
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-11 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 21:49 [PATCH] scsi: fnic: Remove unnecessary debug print Karan Tilak Kumar
2025-03-04 3:05 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox