* [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()
@ 2025-05-14 3:28 Chen Ni
2025-05-14 8:03 ` John Garry
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen Ni @ 2025-05-14 3:28 UTC (permalink / raw)
To: dgilbert, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, Chen Ni
unregister_sysctl_table() checks for NULL pointers internally.
Remove unneeded NULL check here.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/scsi/sg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index effb7e768165..3c02a5f7b5f3 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1658,8 +1658,7 @@ static void register_sg_sysctls(void)
static void unregister_sg_sysctls(void)
{
- if (hdr)
- unregister_sysctl_table(hdr);
+ unregister_sysctl_table(hdr);
}
#else
#define register_sg_sysctls() do { } while (0)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()
2025-05-14 3:28 [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
@ 2025-05-14 8:03 ` John Garry
2025-05-21 2:00 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2025-05-14 8:03 UTC (permalink / raw)
To: Chen Ni, dgilbert, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel
On 14/05/2025 04:28, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
>
> Signed-off-by: Chen Ni<nichen@iscas.ac.cn>
> ---
Reviewed-by: John Garry <john.g.garry@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()
2025-05-14 3:28 [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-05-14 8:03 ` John Garry
@ 2025-05-21 2:00 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-05-21 2:00 UTC (permalink / raw)
To: Chen Ni
Cc: dgilbert, James.Bottomley, martin.petersen, linux-scsi,
linux-kernel
Chen,
> unregister_sysctl_table() checks for NULL pointers internally. Remove
> unneeded NULL check here.
Applied to 6.16/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()
2025-05-14 3:28 [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-05-14 8:03 ` John Garry
2025-05-21 2:00 ` Martin K. Petersen
@ 2025-05-28 2:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-05-28 2:20 UTC (permalink / raw)
To: dgilbert, James.Bottomley, Chen Ni
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Wed, 14 May 2025 11:28:45 +0800, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
>
>
Applied to 6.16/scsi-queue, thanks!
[1/1] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()
https://git.kernel.org/mkp/scsi/c/25c2758e6e72
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-28 2:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 3:28 [PATCH] scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-05-14 8:03 ` John Garry
2025-05-21 2:00 ` Martin K. Petersen
2025-05-28 2:20 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox