* [PATCH] [SCSI] qla4xxx: remove unused count variable
@ 2023-03-31 17:57 Tom Rix
2023-04-03 1:49 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-31 17:57 UTC (permalink / raw)
To: njavali, mrangankar, jejb, martin.petersen, nathan, ndesaulniers
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, llvm,
Tom Rix
clang with W=1 reports
drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]
uint32_t count = 0;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/qla4xxx/ql4_isr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_isr.c b/drivers/scsi/qla4xxx/ql4_isr.c
index 6f0e77dc2a34..cf52258ecdde 100644
--- a/drivers/scsi/qla4xxx/ql4_isr.c
+++ b/drivers/scsi/qla4xxx/ql4_isr.c
@@ -472,14 +472,12 @@ static void qla4xxx_mbox_status_entry(struct scsi_qla_host *ha,
**/
void qla4xxx_process_response_queue(struct scsi_qla_host *ha)
{
- uint32_t count = 0;
struct srb *srb = NULL;
struct status_entry *sts_entry;
/* Process all responses from response queue */
while ((ha->response_ptr->signature != RESPONSE_PROCESSED)) {
sts_entry = (struct status_entry *) ha->response_ptr;
- count++;
/* Advance pointers for next entry */
if (ha->response_out == (RESPONSE_QUEUE_DEPTH - 1)) {
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] [SCSI] qla4xxx: remove unused count variable
2023-03-31 17:57 [PATCH] [SCSI] qla4xxx: remove unused count variable Tom Rix
@ 2023-04-03 1:49 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-03 1:49 UTC (permalink / raw)
To: Tom Rix
Cc: njavali, mrangankar, jejb, martin.petersen, nathan, ndesaulniers,
GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, llvm
Tom,
> clang with W=1 reports
> drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
> 'count' set but not used [-Werror,-Wunused-but-set-variable]
> uint32_t count = 0;
> ^
> This variable is not used so remove it.
Applied to 6.4/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [SCSI] qla4xxx: remove unused count variable
2023-03-31 17:57 [PATCH] [SCSI] qla4xxx: remove unused count variable Tom Rix
2023-04-03 1:49 ` Martin K. Petersen
@ 2023-04-12 2:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-12 2:04 UTC (permalink / raw)
To: njavali, mrangankar, jejb, nathan, ndesaulniers, Tom Rix
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux-scsi,
linux-kernel, llvm
On Fri, 31 Mar 2023 13:57:57 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
> 'count' set but not used [-Werror,-Wunused-but-set-variable]
> uint32_t count = 0;
> ^
> This variable is not used so remove it.
>
> [...]
Applied to 6.4/scsi-queue, thanks!
[1/1] qla4xxx: remove unused count variable
https://git.kernel.org/mkp/scsi/c/3d2efb5470f5
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 2:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-31 17:57 [PATCH] [SCSI] qla4xxx: remove unused count variable Tom Rix
2023-04-03 1:49 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox