[PATCH] cciss: remove unneeded void pointer cast

[PATCH] cciss: remove unneeded void pointer cast

[Javier Martinez Canillas]

It's not necessary to cast the result of kmalloc, since void pointers are
promoted to any other type. This also fixes following coccinelle warning:

casting value returned by memory allocation function to (struct cciss_scsi_adapter_data_t *) is useless.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/block/cciss_scsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c
index 1537302e56e3..06692f164f40 100644
--- a/drivers/block/cciss_scsi.c
+++ b/drivers/block/cciss_scsi.c
@@ -703,8 +703,7 @@ cciss_scsi_setup(ctlr_info_t *h)
 	struct cciss_scsi_adapter_data_t * shba;
 
 	ccissscsi[h->ctlr].ndevices = 0;
-	shba = (struct cciss_scsi_adapter_data_t *)
-		kmalloc(sizeof(*shba), GFP_KERNEL);	
+	shba = kmalloc(sizeof(*shba), GFP_KERNEL);
 	if (shba == NULL)
 		return;
 	shba->scsi_host = NULL;
-- 
2.7.4

Re: [PATCH] cciss: remove unneeded void pointer cast

[Javier Martinez Canillas]

Hello Don,

On 10/13/2016 03:12 PM, Don Brace wrote:
>> -----Original Message-----
>> From: Javier Martinez Canillas [mailto:javier@osg.samsung.com]
>> Sent: Thursday, October 13, 2016 11:11 AM
>> To: linux-kernel@vger.kernel.org
>> Cc: Javier Martinez Canillas; esc.storagedev; iss_storagedev@hp.com; Don
>> Brace; linux-scsi@vger.kernel.org
>> Subject: [PATCH] cciss: remove unneeded void pointer cast
>>
>> EXTERNAL EMAIL
>>
>>
>> It's not necessary to cast the result of kmalloc, since void pointers are
>> promoted to any other type. This also fixes following coccinelle warning:
>>
>> casting value returned by memory allocation function to (struct
>> cciss_scsi_adapter_data_t *) is useless.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Acked-by: Don Brace <don.brace@microsemi.com>
>> ---

Thanks for the ack. Do you know who is supposed to pick this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] cciss: remove unneeded void pointer cast

[Martin K. Petersen]

>>>>> "Javier" == Javier Martinez Canillas <javier@osg.samsung.com> writes:

>>> casting value returned by memory allocation function to (struct
>>> cciss_scsi_adapter_data_t *) is useless.
>>> 
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> 
>> Acked-by: Don Brace <don.brace@microsemi.com>

Javier> Thanks for the ack. Do you know who is supposed to pick this
Javier> patch?

I'm happy to queue it. However, I never saw Don's ack and neither did
patchwork. Was that done in a private email?

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] cciss: remove unneeded void pointer cast

[Javier Martinez Canillas]

Hello Martin,

On 11/29/2016 01:35 PM, Martin K. Petersen wrote:
>>>>>> "Javier" == Javier Martinez Canillas <javier@osg.samsung.com> writes:
> 
>>>> casting value returned by memory allocation function to (struct
>>>> cciss_scsi_adapter_data_t *) is useless.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Acked-by: Don Brace <don.brace@microsemi.com>
> 
> Javier> Thanks for the ack. Do you know who is supposed to pick this
> Javier> patch?
> 
> I'm happy to queue it. However, I never saw Don's ack and neither did
> patchwork. Was that done in a private email?
> 

Strange, it wasn't a private email but for some reason I see that it
didn't made it to neither LKML nor linux-scsi indeed. I was also not
able to find it in those archives.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] cciss: remove unneeded void pointer cast

[Martin K. Petersen]

>>>>> "Javier" == Javier Martinez Canillas <javier@osg.samsung.com> writes:

>> I'm happy to queue it. However, I never saw Don's ack and neither did
>> patchwork. Was that done in a private email?

Javier> Strange, it wasn't a private email but for some reason I see
Javier> that it didn't made it to neither LKML nor linux-scsi indeed. I
Javier> was also not able to find it in those archives.

Don: Please re-ack so we get it in the archives. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering