* [PATCH] scsi: fnic: return error if vmalloc failed
@ 2023-11-28 11:10 Artem Chernyshev
2023-11-29 2:27 ` Karan Tilak Kumar (kartilak)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Artem Chernyshev @ 2023-11-28 11:10 UTC (permalink / raw)
To: Satish Kharat, Sesidhar Baddela
Cc: Artem Chernyshev, Karan Tilak Kumar, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, linux-kernel, lvc-project
In fnic_init_module() exists redundant check for return value
from fnic_debugfs_init(), because at moment it only can
return zero. It make sense to process theoretical vmalloc failure.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 9730ddfb123d ("scsi: fnic: remove redundant assignment of variable rc")
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
drivers/scsi/fnic/fnic_debugfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
index c4d9ed0d7d75..cf2601bf170a 100644
--- a/drivers/scsi/fnic/fnic_debugfs.c
+++ b/drivers/scsi/fnic/fnic_debugfs.c
@@ -52,9 +52,10 @@ int fnic_debugfs_init(void)
fc_trc_flag->fnic_trace = 2;
fc_trc_flag->fc_trace = 3;
fc_trc_flag->fc_clear = 4;
+ return 0;
}
- return 0;
+ return -ENOMEM;
}
/*
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: fnic: return error if vmalloc failed
2023-11-28 11:10 [PATCH] scsi: fnic: return error if vmalloc failed Artem Chernyshev
@ 2023-11-29 2:27 ` Karan Tilak Kumar (kartilak)
2023-12-06 1:48 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2023-11-29 2:27 UTC (permalink / raw)
To: Artem Chernyshev, Satish Kharat (satishkh),
Sesidhar Baddela (sebaddel)
Cc: James E . J . Bottomley, Martin K . Petersen,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
On Tuesday, November 28, 2023 3:10 AM, Artem Chernyshev <artem.chernyshev@red-soft.ru> wrote:
>
> In fnic_init_module() exists redundant check for return value from fnic_debugfs_init(), because at moment it only can return zero. It make sense to process theoretical vmalloc failure.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 9730ddfb123d ("scsi: fnic: remove redundant assignment of variable rc")
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
> ---
> drivers/scsi/fnic/fnic_debugfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
> index c4d9ed0d7d75..cf2601bf170a 100644
> --- a/drivers/scsi/fnic/fnic_debugfs.c
> +++ b/drivers/scsi/fnic/fnic_debugfs.c
> @@ -52,9 +52,10 @@ int fnic_debugfs_init(void)
> fc_trc_flag->fnic_trace = 2;
> fc_trc_flag->fc_trace = 3;
> fc_trc_flag->fc_clear = 4;
> + return 0;
> }
>
> - return 0;
> + return -ENOMEM;
> }
>
> /*
> --
> 2.37.3
Looks good to me.
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: return error if vmalloc failed
2023-11-28 11:10 [PATCH] scsi: fnic: return error if vmalloc failed Artem Chernyshev
2023-11-29 2:27 ` Karan Tilak Kumar (kartilak)
@ 2023-12-06 1:48 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-12-06 1:48 UTC (permalink / raw)
To: Artem Chernyshev
Cc: Satish Kharat, Sesidhar Baddela, Karan Tilak Kumar,
James E . J . Bottomley, Martin K . Petersen, linux-scsi,
linux-kernel, lvc-project
Artem,
> In fnic_init_module() exists redundant check for return value from
> fnic_debugfs_init(), because at moment it only can return zero. It
> make sense to process theoretical vmalloc failure.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: return error if vmalloc failed
2023-11-28 11:10 [PATCH] scsi: fnic: return error if vmalloc failed Artem Chernyshev
2023-11-29 2:27 ` Karan Tilak Kumar (kartilak)
2023-12-06 1:48 ` Martin K. Petersen
@ 2023-12-14 4:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-12-14 4:29 UTC (permalink / raw)
To: Satish Kharat, Sesidhar Baddela, Artem Chernyshev
Cc: Martin K . Petersen, Karan Tilak Kumar, James E . J . Bottomley,
linux-scsi, linux-kernel, lvc-project
On Tue, 28 Nov 2023 14:10:08 +0300, Artem Chernyshev wrote:
> In fnic_init_module() exists redundant check for return value
> from fnic_debugfs_init(), because at moment it only can
> return zero. It make sense to process theoretical vmalloc failure.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: fnic: return error if vmalloc failed
https://git.kernel.org/mkp/scsi/c/f5f27a332a14
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-14 4:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 11:10 [PATCH] scsi: fnic: return error if vmalloc failed Artem Chernyshev
2023-11-29 2:27 ` Karan Tilak Kumar (kartilak)
2023-12-06 1:48 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox