public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Meneghini <jmeneghi@redhat.com>
Cc: Sagar.Biradar@microchip.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, thenzl@redhat.com,
	mpatalan@redhat.com, Scott.Benesh@microchip.com,
	Don.Brace@microchip.com, Tom.White@microchip.com,
	Abhinav.Kuchibhotla@microchip.com
Subject: Re: [PATCH] [v2]aacraid: Reply queue mapping to CPUs based on IRQ affinity
Date: Thu, 20 Feb 2025 21:38:37 -0500	[thread overview]
Message-ID: <yq1eczsjaaz.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <8433b8b8-bb9a-43e0-a760-d8745d28d0d9@redhat.com> (John Meneghini's message of "Thu, 13 Feb 2025 17:03:50 -0500")


John,

> However, I agree it would be better to just fix the driver,
> performance impact notwithstanding, and ship it. For my part I'd
> rather have a correctly functioning driver, that's slower, but doesn't
> panic.

I prefer to have a driver that doesn't panic when the user performs a
reasonably normal administrative action.

If go-faster stripes are desired in specific configurations, then make
the performance mode an opt-in. Based on your benchmarks, however, I'm
not entirely convinced it's worth it...

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2025-02-21  2:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30 17:33 [PATCH] [v2]aacraid: Reply queue mapping to CPUs based on IRQ affinity Sagar Biradar
2025-02-10 17:20 ` John Meneghini
2025-02-10 20:24   ` John Meneghini
2025-02-13  2:56 ` Martin K. Petersen
2025-02-13 21:26   ` Sagar.Biradar
     [not found]     ` <PH7PR11MB7570E9E65153C48BA7C5679EFAFF2@PH7PR11MB7570.namprd11.prod.outlook.com>
2025-02-13 21:31       ` Sagar.Biradar
2025-02-13 22:03     ` John Meneghini
2025-02-13 22:21       ` John Meneghini
2025-02-21  2:38       ` Martin K. Petersen [this message]
2025-02-24 21:15         ` John Meneghini
2025-03-10 16:44           ` Hannes Reinecke
2025-03-11  1:16             ` Martin K. Petersen
2025-03-12  1:52             ` John Meneghini
2025-03-25  0:16               ` Sagar.Biradar
2025-03-25  1:54                 ` John Garry
2025-04-17 16:02                   ` Sagar.Biradar
2025-04-22  6:42                     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1eczsjaaz.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=Abhinav.Kuchibhotla@microchip.com \
    --cc=Don.Brace@microchip.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Sagar.Biradar@microchip.com \
    --cc=Scott.Benesh@microchip.com \
    --cc=Tom.White@microchip.com \
    --cc=jmeneghi@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mpatalan@redhat.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox