From: "Martin K. Petersen (Oracle)" <mkp@kernel.org>
To: Stanley Jhu <stanleyjhu@google.com>
Cc: "Martin K. Petersen" <mkp@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
"James E . J . Bottomley"
<James.Bottomley@hansenpartnership.com>,
Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
Bean Huo <beanhuo@micron.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v6 00/40] Use defined 16-bits ASC/ASCQ combinations
Date: Mon, 28 Sep 2026 21:23:11 -0400 [thread overview]
Message-ID: <yq1jyo4onqe.fsf@mail.kernel.org> (raw)
In-Reply-To: <18d98009e8d5679e.3137322e31362e3131332e313435.256270.0000sendgmr@google.com>
Stanley,
> The merge resolution in 670f07403f7c [1] converted the UFS RPMB entry
> added by a8a34238e5e6 ("scsi: ufs: rpmb: Retry power-on UNIT ATTENTION
> on the RPMB WLUN") to:
>
> .sense_code = POWER_ON_RESET_OR_BUS_DEVICE_RESET_OCCURRED,
>
> The original entry used .ascq = SCMD_FAILURE_ASCQ_ANY. With the
> combined code the ASCQ is now 00h, so scsi_check_passthrough() retries
> 29h/00h only and no longer the other 29h ASCQs, e.g. 29h/01h POWER ON
> OCCURRED. Following the convention used in sd.c, the equivalent would
> be:
>
> .sense_code = POWER_ON_RESET_OR_BUS_DEVICE_RESET_OCCURRED |
> SCMD_FAILURE_ASCQ_ANY,
>
> Could you fold that into the merge, or would you prefer a separate
> patch?
Sorry about that! So many conflicts this cycle.
Please send a separate patch. Thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-09-29 1:23 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 9:02 [PATCH v6 00/40] Use defined 16-bits ASC/ASCQ combinations Damien Le Moal
2026-09-08 9:02 ` [PATCH v6 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-08 9:39 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-08 9:12 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-08 9:10 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-08 9:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-08 9:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-08 9:17 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-08 9:24 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 08/40] scsi: sd: " Damien Le Moal
2026-09-08 9:26 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 09/40] scsi: sr: " Damien Le Moal
2026-09-08 9:27 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 10/40] scsi: ses: " Damien Le Moal
2026-09-08 9:33 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 11/40] scsi: ch: " Damien Le Moal
2026-09-08 9:32 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 12/40] scsi: st: " Damien Le Moal
2026-09-08 9:33 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-08 9:35 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-08 9:37 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-08 9:37 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-08 9:43 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-08 9:48 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-08 9:42 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 19/40] scsi: 3w-xxxx: " Damien Le Moal
2026-09-08 9:51 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 20/40] scsi: leapraid: " Damien Le Moal
2026-09-08 9:50 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 21/40] scsi: megaraid: " Damien Le Moal
2026-09-08 9:48 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 22/40] scsi: myrX: " Damien Le Moal
2026-09-08 9:59 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-08 9:54 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-08 9:58 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 25/40] scsi: ps3rom: " Damien Le Moal
2026-09-08 10:05 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 26/40] scsi: lpfc: " Damien Le Moal
2026-09-08 10:03 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 27/40] scsi: stex: " Damien Le Moal
2026-09-08 10:14 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 28/40] scsi: mvumi: " Damien Le Moal
2026-09-08 10:12 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-08 10:08 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-08 10:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-08 10:20 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 32/40] scsi: hpsa: " Damien Le Moal
2026-09-08 10:19 ` sashiko-bot
2026-09-09 19:02 ` Don.Brace
2026-09-08 9:03 ` [PATCH v6 33/40] scsi: storvsc: " Damien Le Moal
2026-09-08 10:28 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 34/40] target: " Damien Le Moal
2026-09-08 10:29 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 35/40] usb: storage: " Damien Le Moal
2026-09-08 10:27 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 36/40] cdrom: " Damien Le Moal
2026-09-08 10:24 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 37/40] ata: libata: " Damien Le Moal
2026-09-08 10:33 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 38/40] s390: scsi: " Damien Le Moal
2026-09-08 10:34 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-08 10:36 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-08 10:32 ` sashiko-bot
2026-09-17 1:55 ` [PATCH v6 00/40] Use defined 16-bits ASC/ASCQ combinations Martin K. Petersen (Oracle)
2026-09-28 13:45 ` Stanley Jhu
2026-09-29 1:23 ` Martin K. Petersen (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1jyo4onqe.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=beanhuo@micron.com \
--cc=dlemoal@kernel.org \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox