* [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value
@ 2025-02-26 6:52 Shawn Lin
2025-03-04 2:12 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Shawn Lin @ 2025-02-26 6:52 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen; +Cc: linux-scsi, Shawn Lin
A positive value is for the number of clocks obtained if assigned.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/ufs/host/ufs-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
index 5b0ea98..c4d561f 100644
--- a/drivers/ufs/host/ufs-rockchip.c
+++ b/drivers/ufs/host/ufs-rockchip.c
@@ -171,7 +171,7 @@ static int ufs_rockchip_common_init(struct ufs_hba *hba)
"failed to get reset gpio\n");
err = devm_clk_bulk_get_all_enabled(dev, &host->clks);
- if (err)
+ if (err < 0)
return dev_err_probe(dev, err, "failed to enable clocks\n");
host->hba = hba;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value
2025-02-26 6:52 [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value Shawn Lin
@ 2025-03-04 2:12 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-03-04 2:12 UTC (permalink / raw)
To: Shawn Lin; +Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Shawn,
> A positive value is for the number of clocks obtained if assigned.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value
2025-02-26 6:52 [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value Shawn Lin
2025-03-04 2:12 ` Martin K. Petersen
@ 2025-03-11 1:19 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-03-11 1:19 UTC (permalink / raw)
To: James E . J . Bottomley, Shawn Lin; +Cc: Martin K . Petersen, linux-scsi
On Wed, 26 Feb 2025 14:52:13 +0800, Shawn Lin wrote:
> A positive value is for the number of clocks obtained if assigned.
>
>
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value
https://git.kernel.org/mkp/scsi/c/4fffffd3b134
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-11 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 6:52 [PATCH -next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value Shawn Lin
2025-03-04 2:12 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox