* [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif
@ 2024-09-30 20:13 Bart Van Assche
2024-10-04 1:46 ` Martin K. Petersen
2024-10-16 2:40 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2024-09-30 20:13 UTC (permalink / raw)
To: Martin K . Petersen
Cc: linux-scsi, Bart Van Assche, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, MPT-FusionLinux.pdl
Except for preventing build errors, there shouldn't be any conditionals in
kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
pair from the MPT Fusion driver.
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: MPT-FusionLinux.pdl@broadcom.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/message/fusion/mptlan.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/message/fusion/mptlan.h b/drivers/message/fusion/mptlan.h
index a1ec7e84d6fe..40b34f670065 100644
--- a/drivers/message/fusion/mptlan.h
+++ b/drivers/message/fusion/mptlan.h
@@ -51,10 +51,7 @@
#define LINUX_MPTLAN_H_INCLUDED
/*****************************************************************************/
-#if !defined(__GENKSYMS__)
#include <linux/module.h>
-#endif
-
#include <linux/netdevice.h>
#include <linux/errno.h>
// #include <linux/etherdevice.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif
2024-09-30 20:13 [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif Bart Van Assche
@ 2024-10-04 1:46 ` Martin K. Petersen
2024-10-16 2:40 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-10-04 1:46 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, MPT-FusionLinux.pdl
Bart,
> Except for preventing build errors, there shouldn't be any conditionals in
> kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
> pair from the MPT Fusion driver.
Applied to 6.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif
2024-09-30 20:13 [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif Bart Van Assche
2024-10-04 1:46 ` Martin K. Petersen
@ 2024-10-16 2:40 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-10-16 2:40 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, MPT-FusionLinux.pdl
On Mon, 30 Sep 2024 13:13:47 -0700, Bart Van Assche wrote:
> Except for preventing build errors, there shouldn't be any conditionals in
> kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
> pair from the MPT Fusion driver.
>
>
Applied to 6.13/scsi-queue, thanks!
[1/1] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif
https://git.kernel.org/mkp/scsi/c/09822c231ae6
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-16 2:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 20:13 [PATCH] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif Bart Van Assche
2024-10-04 1:46 ` Martin K. Petersen
2024-10-16 2:40 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox