* [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h
@ 2021-09-17 21:27 Bart Van Assche
2021-09-20 14:01 ` Himanshu Madhani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bart Van Assche @ 2021-09-17 21:27 UTC (permalink / raw)
To: Martin K . Petersen; +Cc: linux-scsi, Bart Van Assche, Kashyap Desai
There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h>
header file. Hence remove the scsi_host.h include directive from
scsi_cmnd.h. This include directive was introduced in February 2021 by
commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").
Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/scsi/scsi_cmnd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
index eaf04c9a1dfc..a2315aac93c7 100644
--- a/include/scsi/scsi_cmnd.h
+++ b/include/scsi/scsi_cmnd.h
@@ -10,7 +10,6 @@
#include <linux/timer.h>
#include <linux/scatterlist.h>
#include <scsi/scsi_device.h>
-#include <scsi/scsi_host.h>
#include <scsi/scsi_request.h>
struct Scsi_Host;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h
2021-09-17 21:27 [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h Bart Van Assche
@ 2021-09-20 14:01 ` Himanshu Madhani
2021-09-22 3:55 ` Martin K. Petersen
2021-09-29 4:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2021-09-20 14:01 UTC (permalink / raw)
To: Bart Van Assche; +Cc: Martin Petersen, linux-scsi, Kashyap Desai
> On Sep 17, 2021, at 4:27 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h>
> header file. Hence remove the scsi_host.h include directive from
> scsi_cmnd.h. This include directive was introduced in February 2021 by
> commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").
>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> include/scsi/scsi_cmnd.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
> index eaf04c9a1dfc..a2315aac93c7 100644
> --- a/include/scsi/scsi_cmnd.h
> +++ b/include/scsi/scsi_cmnd.h
> @@ -10,7 +10,6 @@
> #include <linux/timer.h>
> #include <linux/scatterlist.h>
> #include <scsi/scsi_device.h>
> -#include <scsi/scsi_host.h>
> #include <scsi/scsi_request.h>
>
> struct Scsi_Host;
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h
2021-09-17 21:27 [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h Bart Van Assche
2021-09-20 14:01 ` Himanshu Madhani
@ 2021-09-22 3:55 ` Martin K. Petersen
2021-09-29 4:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-09-22 3:55 UTC (permalink / raw)
To: Bart Van Assche; +Cc: Martin K . Petersen, linux-scsi, Kashyap Desai
Bart,
> There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h>
> header file. Hence remove the scsi_host.h include directive from
> scsi_cmnd.h. This include directive was introduced in February 2021 by
> commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h
2021-09-17 21:27 [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h Bart Van Assche
2021-09-20 14:01 ` Himanshu Madhani
2021-09-22 3:55 ` Martin K. Petersen
@ 2021-09-29 4:20 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-09-29 4:20 UTC (permalink / raw)
To: Bart Van Assche; +Cc: Martin K . Petersen, Kashyap Desai, linux-scsi
On Fri, 17 Sep 2021 14:27:51 -0700, Bart Van Assche wrote:
> There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h>
> header file. Hence remove the scsi_host.h include directive from
> scsi_cmnd.h. This include directive was introduced in February 2021 by
> commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").
>
>
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h
https://git.kernel.org/mkp/scsi/c/a7c052066986
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-29 4:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-17 21:27 [PATCH] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h Bart Van Assche
2021-09-20 14:01 ` Himanshu Madhani
2021-09-22 3:55 ` Martin K. Petersen
2021-09-29 4:20 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox