From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI: Make error printing more user friendly
Date: Mon, 19 Feb 2007 10:43:09 -0500 [thread overview]
Message-ID: <yq1k5yeqhki.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1171638659.3443.8.camel@mulgrave.il.steeleye.com> (James Bottomley's message of "Fri, 16 Feb 2007 09:10:59 -0600")
>>>>> "James" == James Bottomley <James.Bottomley@SteelEye.com> writes:
James> I think we should be going through dev_printk as the primary,
James> particularly as doing this would make the output of sdev_printk
James> different from scmd_printk. How about
Fine with me except we're now back to having inconsistent prefixes for
the result printing and the matching sense data.
I'll try to sanitize the sense printing too and post a new patch.
James> The other nasty is that we can't actually deref rq_disk unless
James> <linux/blkdev.h> is included. You'll find megaraid_sas.c fails
James> to compile becuase of this. It can probably be fixed by
James> including blkdev.h from scsi_device.h
You must have had a reject on scsi_device.h. My patch did include
<linux/blkdev.h> to fix that very issue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2007-02-19 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 8:03 [PATCH] SCSI: Make error printing more user friendly Martin K. Petersen
2007-02-16 15:10 ` James Bottomley
2007-02-19 15:43 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k5yeqhki.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox