* RE: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h
2022-11-03 5:53 ` [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h Keoseong Park
@ 2022-11-03 7:04 ` Avri Altman
2022-11-08 3:06 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2022-11-03 7:04 UTC (permalink / raw)
To: keosung.park@samsung.com, martin.petersen@oracle.com,
bvanassche@acm.org, beanhuo@micron.com, adrian.hunter@intel.com,
stanley.chu@mediatek.com, yoshihiro.shimoda.uh@renesas.com,
draviv@codeaurora.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate device
> initialization") added check_upiu_size(), but no caller.
Nor there ever was.
>
> Cc: Dolev Raviv <draviv@codeaurora.org>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> include/ufs/ufshcd.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 96538eb3a6c0..5cf81dff60aa 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val); void ufshcd_hba_stop(struct ufs_hba *hba); void
> ufshcd_schedule_eh_work(struct ufs_hba *hba);
>
> -static inline void check_upiu_size(void) -{
> - BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
> - GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
> -}
> -
> /**
> * ufshcd_set_variant - set variant specific data to the hba
> * @hba: per adapter instance
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h
2022-11-03 5:53 ` [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h Keoseong Park
2022-11-03 7:04 ` Avri Altman
@ 2022-11-08 3:06 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-11-08 3:06 UTC (permalink / raw)
To: Keoseong Park
Cc: martin.petersen@oracle.com, bvanassche@acm.org,
beanhuo@micron.com, avri.altman@wdc.com, adrian.hunter@intel.com,
stanley.chu@mediatek.com, yoshihiro.shimoda.uh@renesas.com,
draviv@codeaurora.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Keoseong,
> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h
2022-11-03 5:53 ` [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h Keoseong Park
2022-11-03 7:04 ` Avri Altman
2022-11-08 3:06 ` Martin K. Petersen
@ 2022-11-17 18:29 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-11-17 18:29 UTC (permalink / raw)
To: adrian.hunter, bvanassche, Keoseong Park, linux-kernel,
yoshihiro.shimoda.uh, draviv, beanhuo, stanley.chu, linux-scsi,
avri.altman
Cc: Martin K . Petersen
On Thu, 03 Nov 2022 14:53:49 +0900, Keoseong Park wrote:
> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: ufs: Remove check_upiu_size() from ufshcd.h
https://git.kernel.org/mkp/scsi/c/3d6d7930928a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread