* [PATCH] scsi: ufs: core: Increase the UIC command timeout further
@ 2025-05-08 16:54 Bart Van Assche
2025-05-09 6:54 ` Peter Wang (王信友)
2025-05-13 2:32 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2025-05-08 16:54 UTC (permalink / raw)
To: Martin K . Petersen
Cc: linux-scsi, Bart Van Assche, James E.J. Bottomley, Peter Wang,
Avri Altman, Manivannan Sadhasivam, Bao D. Nguyen
On my development board I observed that it can take a little longer than
two seconds before UIC completions are processed if the UART is enabled.
Hence this patch that increases the UIC command timeout upper limit
further.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 2d39924a32b0..b18ba17c22ff 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -54,7 +54,7 @@
/* UIC command timeout, unit: ms */
enum {
UIC_CMD_TIMEOUT_DEFAULT = 500,
- UIC_CMD_TIMEOUT_MAX = 2000,
+ UIC_CMD_TIMEOUT_MAX = 5000,
};
/* NOP OUT retries waiting for NOP IN response */
#define NOP_OUT_RETRIES 10
@@ -134,7 +134,7 @@ static const struct kernel_param_ops uic_cmd_timeout_ops = {
module_param_cb(uic_cmd_timeout, &uic_cmd_timeout_ops, &uic_cmd_timeout, 0644);
MODULE_PARM_DESC(uic_cmd_timeout,
- "UFS UIC command timeout in milliseconds. Defaults to 500ms. Supported values range from 500ms to 2 seconds inclusively");
+ "UFS UIC command timeout in milliseconds. Defaults to 500ms. Supported values range from 500ms to 5 seconds inclusively");
#define ufshcd_toggle_vreg(_dev, _vreg, _on) \
({ \
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: core: Increase the UIC command timeout further
2025-05-08 16:54 [PATCH] scsi: ufs: core: Increase the UIC command timeout further Bart Van Assche
@ 2025-05-09 6:54 ` Peter Wang (王信友)
2025-05-13 2:32 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Peter Wang (王信友) @ 2025-05-09 6:54 UTC (permalink / raw)
To: bvanassche@acm.org, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, manivannan.sadhasivam@linaro.org,
James.Bottomley@HansenPartnership.com, avri.altman@wdc.com,
quic_nguyenb@quicinc.com
On Thu, 2025-05-08 at 09:54 -0700, Bart Van Assche wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On my development board I observed that it can take a little longer
> than
> two seconds before UIC completions are processed if the UART is
> enabled.
> Hence this patch that increases the UIC command timeout upper limit
> further.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/core/ufshcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 2d39924a32b0..b18ba17c22ff 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -54,7 +54,7 @@
> /* UIC command timeout, unit: ms */
> enum {
> UIC_CMD_TIMEOUT_DEFAULT = 500,
> - UIC_CMD_TIMEOUT_MAX = 2000,
> + UIC_CMD_TIMEOUT_MAX = 5000,
> };
> /* NOP OUT retries waiting for NOP IN response */
> #define NOP_OUT_RETRIES 10
> @@ -134,7 +134,7 @@ static const struct kernel_param_ops
> uic_cmd_timeout_ops = {
>
> module_param_cb(uic_cmd_timeout, &uic_cmd_timeout_ops,
> &uic_cmd_timeout, 0644);
> MODULE_PARM_DESC(uic_cmd_timeout,
> - "UFS UIC command timeout in milliseconds. Defaults
> to 500ms. Supported values range from 500ms to 2 seconds
> inclusively");
> + "UFS UIC command timeout in milliseconds. Defaults
> to 500ms. Supported values range from 500ms to 5 seconds
> inclusively");
>
> #define ufshcd_toggle_vreg(_dev, _vreg,
> _on) \
>
> ({ \
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: core: Increase the UIC command timeout further
2025-05-08 16:54 [PATCH] scsi: ufs: core: Increase the UIC command timeout further Bart Van Assche
2025-05-09 6:54 ` Peter Wang (王信友)
@ 2025-05-13 2:32 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-05-13 2:32 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, James E.J. Bottomley, Peter Wang,
Avri Altman, Manivannan Sadhasivam, Bao D. Nguyen
Bart,
> On my development board I observed that it can take a little longer than
> two seconds before UIC completions are processed if the UART is enabled.
> Hence this patch that increases the UIC command timeout upper limit
> further.
Applied to 6.16/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-13 2:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 16:54 [PATCH] scsi: ufs: core: Increase the UIC command timeout further Bart Van Assche
2025-05-09 6:54 ` Peter Wang (王信友)
2025-05-13 2:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox