Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH v2 0/7] scsi: qla2xxx: Fix races, leaks and inverted logic found in review
@ 2026-11-03 12:31 Daniel Wagner
  2026-11-03 12:31 ` [PATCH v2 1/7] scsi: qla2xxx: Check FCE state under fce_mutex in debugfs release Daniel Wagner
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Daniel Wagner @ 2026-11-03 12:31 UTC (permalink / raw)
  To: Nilesh Javali, GR-QLogic-Storage-Upstream, Martin K. Petersen,
	Himanshu Madhani, Quinn Tran
  Cc: linux-scsi, Daniel Wagner, stable

A review of recent qla2xxx changes turned up a handful of bugs in
commits that are already upstream and partly marked for stable:

 - debugfs: fce_release checks the FCE state outside fce_mutex and
   can memset a buffer a concurrent write has just freed
 - fabric scan: the "scan active" early exit clears SF_SCANNING of
   the scan that is still running and schedules another one
 - bsg: a firmware completion that races with the abort timeout
   leads to a use-after-free and a double bsg_job_done()
 - target: the big CDB allocation failure path frees an
   uninitialized se_cmd, leaking the tag and num_pend_cmds
 - PCI error recovery: IRQ_NO_BALANCING is cleared before and set
   after the reset instead of the other way round
 - NVMe: an unsolicited LS request from a port without an NVMe
   remote port dereferences a NULL pointer
 - SFP: the 64G speed check tests the wrong bit (cosmetic)

All patches are build tested only.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
Changes in v2:
- Add fixes for the fabric scan, bsg timeout, target CDB allocation,
  IRQ_NO_BALANCING, unsolicited NVMe LS and 64G SFP issues.
- Link to v1: https://patch.msgid.link/20261029-qla2xxx-fix-v1-1-7e272ffdc4b8@suse.de

---
Daniel Wagner (7):
      scsi: qla2xxx: Check FCE state under fce_mutex in debugfs release
      scsi: qla2xxx: Don't clear SF_SCANNING of a running fabric scan
      scsi: qla2xxx: Fix use-after-free on late bsg completion
      scsi: qla2xxx: target: Fix cmd release on CDB allocation failure
      scsi: qla2xxx: Fix inverted IRQ_NO_BALANCING toggling around PCI reset
      scsi: qla2xxx: Reject unsolicited NVMe LS from ports without NVMe rport
      scsi: qla2xxx: Use FC_SPEED_2 to check for the 64G SFP speed byte

 drivers/scsi/qla2xxx/qla_bsg.c    | 8 ++++----
 drivers/scsi/qla2xxx/qla_dfs.c    | 8 ++++----
 drivers/scsi/qla2xxx/qla_gs.c     | 4 +++-
 drivers/scsi/qla2xxx/qla_init.c   | 2 +-
 drivers/scsi/qla2xxx/qla_nvme.c   | 9 +++++++++
 drivers/scsi/qla2xxx/qla_os.c     | 4 ++--
 drivers/scsi/qla2xxx/qla_target.c | 3 ++-
 7 files changed, 25 insertions(+), 13 deletions(-)
---
base-commit: c339f4010dea8b0d754f84ace70cd1b089878ef8
change-id: 20261029-qla2xxx-fix-91c92616c10c

Best regards,
--  
Daniel Wagner <dwagner@suse.de>


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-21  2:32 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 12:31 [PATCH v2 0/7] scsi: qla2xxx: Fix races, leaks and inverted logic found in review Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 1/7] scsi: qla2xxx: Check FCE state under fce_mutex in debugfs release Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 2/7] scsi: qla2xxx: Don't clear SF_SCANNING of a running fabric scan Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 3/7] scsi: qla2xxx: Fix use-after-free on late bsg completion Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 4/7] scsi: qla2xxx: target: Fix cmd release on CDB allocation failure Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 5/7] scsi: qla2xxx: Fix inverted IRQ_NO_BALANCING toggling around PCI reset Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 6/7] scsi: qla2xxx: Reject unsolicited NVMe LS from ports without NVMe rport Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 7/7] scsi: qla2xxx: Use FC_SPEED_2 to check for the 64G SFP speed byte Daniel Wagner
2026-11-21  2:32 ` [PATCH v2 0/7] scsi: qla2xxx: Fix races, leaks and inverted logic found in review Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox