From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Carlos Bilbao (Lambda)" <carlos.bilbao@kernel.org>
Cc: martin.petersen@oracle.com, kees@kernel.org, pabeni@redhat.com,
mlombard@redhat.com, kuniyu@google.com,
michael.christie@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
bilbao@vt.edu
Subject: Re: [PATCH v3] scsi: target: iscsi: reject invalid size Extended CDB AHS
Date: Tue, 21 Apr 2026 21:11:33 -0400 [thread overview]
Message-ID: <yq1o6jbls27.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260415040728.187680-1-carlos.bilbao@kernel.org> (Carlos Bilbao's message of "Tue, 14 Apr 2026 21:07:28 -0700")
Carlos,
> If ecdb_ahdr->ahslength is zero, two bugs follow:
>
> kmalloc(be16_to_cpu(ecdb_ahdr->ahslength) + 15, ...)
>
> allocates 15 bytes, but the immediately following memcpy writes
> ISCSI_CDB_SIZE (16) bytes into it, a one-byte heap overflow. Also:
Applied to 7.1/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2026-04-22 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 1:44 [PATCH] scsi: target: iscsi: reject zero-length Extended CDB AHS carlos.bilbao
2026-04-07 9:23 ` Dmitry Bogdanov
2026-04-09 2:23 ` Carlos Bilbao
2026-04-09 2:42 ` [PATCH v2] scsi: target: iscsi: reject invalid size " carlos.bilbao
2026-04-09 9:31 ` Dmitry Bogdanov
2026-04-10 2:49 ` Carlos Bilbao
2026-04-14 2:36 ` Martin K. Petersen
2026-04-15 4:07 ` [PATCH v3] " Carlos Bilbao (Lambda)
2026-04-22 1:11 ` Martin K. Petersen [this message]
2026-04-15 4:08 ` [PATCH v2] " Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o6jbls27.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@kernel.org \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mlombard@redhat.com \
--cc=pabeni@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox