* [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code
@ 2026-10-13 9:59 Andy Shevchenko
2026-10-13 10:41 ` Konrad Dybcio
2026-10-14 2:49 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-10-13 9:59 UTC (permalink / raw)
To: Martin K. Petersen (Oracle), Can Guo, linux-arm-msm, linux-scsi,
linux-kernel
Cc: Manivannan Sadhasivam, James E.J. Bottomley, Andy Shevchenko
While the C11 allows us to define variables in the code, we do not
do this style (see more at [1]). Move the declaration to the top of
the function.
Link: https://lore.kernel.org/lkml/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.camel@HansenPartnership.com/ [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ufs/host/ufs-qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 91a14a32f205..fee9b54ba5e1 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -2439,6 +2439,7 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
static int ufs_qcom_config_esi(struct ufs_hba *hba)
{
struct ufs_qcom_host *host = ufshcd_get_variant(hba);
+ struct ufs_qcom_irq *qi;
int nr_irqs, ret;
if (host->esi_enabled)
@@ -2457,8 +2458,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)
return ret; /* Continue without ESI */
}
- struct ufs_qcom_irq *qi = devm_kcalloc(hba->dev, nr_irqs, sizeof(*qi), GFP_KERNEL);
-
+ qi = devm_kcalloc(hba->dev, nr_irqs, sizeof(*qi), GFP_KERNEL);
if (!qi) {
platform_device_msi_free_irqs_all(hba->dev);
return -ENOMEM;
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code
2026-10-13 9:59 [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code Andy Shevchenko
@ 2026-10-13 10:41 ` Konrad Dybcio
2026-10-14 2:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-10-13 10:41 UTC (permalink / raw)
To: Andy Shevchenko, Martin K. Petersen (Oracle), Can Guo,
linux-arm-msm, linux-scsi, linux-kernel
Cc: Manivannan Sadhasivam, James E.J. Bottomley
On 10/13/26 11:59 AM, Andy Shevchenko wrote:
> While the C11 allows us to define variables in the code, we do not
> do this style (see more at [1]). Move the declaration to the top of
> the function.
>
> Link: https://lore.kernel.org/lkml/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.camel@HansenPartnership.com/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code
2026-10-13 9:59 [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code Andy Shevchenko
2026-10-13 10:41 ` Konrad Dybcio
@ 2026-10-14 2:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2026-10-14 2:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Martin K. Petersen (Oracle), Can Guo, linux-arm-msm, linux-scsi,
linux-kernel, Manivannan Sadhasivam, James E.J. Bottomley
Andy,
> While the C11 allows us to define variables in the code, we do not
> do this style (see more at [1]). Move the declaration to the top of
> the function.
Applied to 7.4/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-14 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-13 9:59 [PATCH v1 1/1] scsi: ufs: ufs-qcom: Don't define variable in the middle of the code Andy Shevchenko
2026-10-13 10:41 ` Konrad Dybcio
2026-10-14 2:49 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox