Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment
@ 2025-09-07 20:27 Alok Tiwari
  2025-09-12 13:18 ` Peter Griffin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alok Tiwari @ 2025-09-07 20:27 UTC (permalink / raw)
  To: alim.akhtar, krzk, peter.griffin, martin.petersen,
	linux-samsung-soc, linux-scsi, linux-arm-kernel
  Cc: alok.a.tiwari, linux-kernel

Fix the comment for SYNC_LEN_G2 in exynos_ufs_config_sync_pattern_mask().
The actual value is 40us, not 44us, matching the configured mask timing.
This change improves code clarity and avoids potential confusion for
readers and maintainers.

No functional changes.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/ufs/host/ufs-exynos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index 513cbcfa10ac..70d195179eba 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -776,7 +776,7 @@ static void exynos_ufs_config_sync_pattern_mask(struct exynos_ufs *ufs,
 	u32 mask, sync_len;
 	enum {
 		SYNC_LEN_G1 = 80 * 1000, /* 80us */
-		SYNC_LEN_G2 = 40 * 1000, /* 44us */
+		SYNC_LEN_G2 = 40 * 1000, /* 40us */
 		SYNC_LEN_G3 = 20 * 1000, /* 20us */
 	};
 	int i;
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment
  2025-09-07 20:27 [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment Alok Tiwari
@ 2025-09-12 13:18 ` Peter Griffin
  2025-09-16  1:43 ` Martin K. Petersen
  2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2025-09-12 13:18 UTC (permalink / raw)
  To: Alok Tiwari
  Cc: alim.akhtar, krzk, martin.petersen, linux-samsung-soc, linux-scsi,
	linux-arm-kernel, linux-kernel

On Sun, 7 Sept 2025 at 21:27, Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
>
> Fix the comment for SYNC_LEN_G2 in exynos_ufs_config_sync_pattern_mask().
> The actual value is 40us, not 44us, matching the configured mask timing.
> This change improves code clarity and avoids potential confusion for
> readers and maintainers.
>
> No functional changes.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment
  2025-09-07 20:27 [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment Alok Tiwari
  2025-09-12 13:18 ` Peter Griffin
@ 2025-09-16  1:43 ` Martin K. Petersen
  2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-16  1:43 UTC (permalink / raw)
  To: Alok Tiwari
  Cc: alim.akhtar, krzk, peter.griffin, martin.petersen,
	linux-samsung-soc, linux-scsi, linux-arm-kernel, linux-kernel


Alok,

> Fix the comment for SYNC_LEN_G2 in exynos_ufs_config_sync_pattern_mask().
> The actual value is 40us, not 44us, matching the configured mask timing.
> This change improves code clarity and avoids potential confusion for
> readers and maintainers.

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment
  2025-09-07 20:27 [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment Alok Tiwari
  2025-09-12 13:18 ` Peter Griffin
  2025-09-16  1:43 ` Martin K. Petersen
@ 2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-20  2:24 UTC (permalink / raw)
  To: alim.akhtar, krzk, peter.griffin, linux-samsung-soc, linux-scsi,
	linux-arm-kernel, Alok Tiwari
  Cc: Martin K . Petersen, linux-kernel

On Sun, 07 Sep 2025 13:27:49 -0700, Alok Tiwari wrote:

> Fix the comment for SYNC_LEN_G2 in exynos_ufs_config_sync_pattern_mask().
> The actual value is 40us, not 44us, matching the configured mask timing.
> This change improves code clarity and avoids potential confusion for
> readers and maintainers.
> 
> No functional changes.
> 
> [...]

Applied to 6.18/scsi-queue, thanks!

[1/1] scsi: ufs: exynos: correct sync pattern mask timing comment
      https://git.kernel.org/mkp/scsi/c/0bd0e43776b6

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-20  2:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-07 20:27 [PATCH] scsi: ufs: exynos: correct sync pattern mask timing comment Alok Tiwari
2025-09-12 13:18 ` Peter Griffin
2025-09-16  1:43 ` Martin K. Petersen
2025-09-20  2:24 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox