From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/3] libfc: fixup command abort handling
Date: Tue, 05 Dec 2023 21:33:44 -0500 [thread overview]
Message-ID: <yq1r0k0m54v.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20231129151408.119844-1-hare@suse.de> (Hannes Reinecke's message of "Wed, 29 Nov 2023 16:14:05 +0100")
Hannes,
> when testing command timeout with the help of XDP I found that
> scsi_try_to_abort_cmd() would always return 'SUCCESS' for FCoE, even
> if no commands could be sent over the wire. Which is not only
> surprising, but also can lead to data corruption as commands were
> never aborted. Root cause was that aborts had been sent twice, once
> from FC error recovery and once from SCSI EH, with the former inducing
> the latter to assume that the command was already aborted.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next parent reply other threads:[~2023-12-06 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231129151408.119844-1-hare@suse.de>
2023-12-06 2:33 ` Martin K. Petersen [this message]
2023-11-29 16:58 [PATCH 0/3] libfc: fixup command abort handling hare
2023-12-14 4:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r0k0m54v.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox