* Re: [PATCH 0/3] libfc: fixup command abort handling
[not found] <20231129151408.119844-1-hare@suse.de>
@ 2023-12-06 2:33 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-12-06 2:33 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K. Petersen, Christoph Hellwig, James Bottomley,
linux-scsi
Hannes,
> when testing command timeout with the help of XDP I found that
> scsi_try_to_abort_cmd() would always return 'SUCCESS' for FCoE, even
> if no commands could be sent over the wire. Which is not only
> surprising, but also can lead to data corruption as commands were
> never aborted. Root cause was that aborts had been sent twice, once
> from FC error recovery and once from SCSI EH, with the former inducing
> the latter to assume that the command was already aborted.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/3] libfc: fixup command abort handling
@ 2023-11-29 16:58 hare
2023-12-14 4:29 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: hare @ 2023-11-29 16:58 UTC (permalink / raw)
To: Martin K. Petersen
Cc: James Bottomley, Christoph Hellwig, linux-scsi, Hannes Reinecke
From: Hannes Reinecke <hare@suse.de>
Hi all,
when testing command timeout with the help of XDP I found
that scsi_try_to_abort_cmd() would always return 'SUCCESS'
for FCoE, even if no commands could be sent over the wire.
Which is not only surprising, but also can lead to data
corruption as commands were never aborted.
Root cause was that aborts had been sent twice, once
from FC error recovery and once from SCSI EH, with the
former inducing the latter to assume that the command
was already aborted.
As usual, comments and reviews are welcome.
Hannes Reinecke (3):
libfc: don't schedule abort twice
libfc: Fixup timeout error in fc_fcp_rec_error()
libfc: map FC_TIMED_OUT to DID_TIME_OUT
drivers/scsi/libfc/fc_fcp.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] libfc: fixup command abort handling
2023-11-29 16:58 hare
@ 2023-12-14 4:29 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-12-14 4:29 UTC (permalink / raw)
To: hare
Cc: Martin K . Petersen, James Bottomley, Christoph Hellwig,
linux-scsi, Hannes Reinecke
On Wed, 29 Nov 2023 17:58:29 +0100, hare@kernel.org wrote:
> when testing command timeout with the help of XDP I found
> that scsi_try_to_abort_cmd() would always return 'SUCCESS'
> for FCoE, even if no commands could be sent over the wire.
> Which is not only surprising, but also can lead to data
> corruption as commands were never aborted.
> Root cause was that aborts had been sent twice, once
> from FC error recovery and once from SCSI EH, with the
> former inducing the latter to assume that the command
> was already aborted.
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/3] libfc: don't schedule abort twice
https://git.kernel.org/mkp/scsi/c/b57c4db5d23b
[2/3] libfc: Fixup timeout error in fc_fcp_rec_error()
https://git.kernel.org/mkp/scsi/c/53122a49f497
[3/3] libfc: map FC_TIMED_OUT to DID_TIME_OUT
https://git.kernel.org/mkp/scsi/c/be40572c22cc
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-14 4:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231129151408.119844-1-hare@suse.de>
2023-12-06 2:33 ` [PATCH 0/3] libfc: fixup command abort handling Martin K. Petersen
2023-11-29 16:58 hare
2023-12-14 4:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox