* [PATCH] ufs/core: ufshcd: Conversion to bool not necessary
@ 2023-10-24 18:34 Bragatheswaran Manickavel
2023-10-24 18:59 ` Bart Van Assche
2023-10-25 2:44 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Bragatheswaran Manickavel @ 2023-10-24 18:34 UTC (permalink / raw)
To: alim.akhtar, avri.altman, bvanassche, jejb, martin.petersen,
stanley.chu, mani, quic_cang, quic_asutoshd, peter.wang, beanhuo,
quic_nguyenb, Arthur.Simchaev
Cc: Bragatheswaran Manickavel, linux-scsi, linux-kernel
A logical evaluation already results in bool. There is no need for using
a ternary operator based evaluation and bool conversion of the outcome.
Issue identified using boolconv.cocci Coccinelle semantic patch.
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 406885671665..bbd8e83be6c6 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2406,7 +2406,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
500, UIC_CMD_TIMEOUT * 1000, false, hba,
REG_CONTROLLER_STATUS);
- return ret == 0 ? true : false;
+ return ret == 0;
}
/**
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ufs/core: ufshcd: Conversion to bool not necessary
2023-10-24 18:34 [PATCH] ufs/core: ufshcd: Conversion to bool not necessary Bragatheswaran Manickavel
@ 2023-10-24 18:59 ` Bart Van Assche
2023-10-25 2:44 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2023-10-24 18:59 UTC (permalink / raw)
To: Bragatheswaran Manickavel, alim.akhtar, avri.altman, jejb,
martin.petersen, stanley.chu, mani, quic_cang, quic_asutoshd,
peter.wang, beanhuo, quic_nguyenb, Arthur.Simchaev
Cc: linux-scsi, linux-kernel
On 10/24/23 11:34, Bragatheswaran Manickavel wrote:
> A logical evaluation already results in bool. There is no need for using
> a ternary operator based evaluation and bool conversion of the outcome.
>
> Issue identified using boolconv.cocci Coccinelle semantic patch.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 406885671665..bbd8e83be6c6 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2406,7 +2406,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
> int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
> 500, UIC_CMD_TIMEOUT * 1000, false, hba,
> REG_CONTROLLER_STATUS);
> - return ret == 0 ? true : false;
> + return ret == 0;
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ufs/core: ufshcd: Conversion to bool not necessary
2023-10-24 18:34 [PATCH] ufs/core: ufshcd: Conversion to bool not necessary Bragatheswaran Manickavel
2023-10-24 18:59 ` Bart Van Assche
@ 2023-10-25 2:44 ` Martin K. Petersen
2023-10-25 3:51 ` Bragatheswaran Manickavel
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-25 2:44 UTC (permalink / raw)
To: Bragatheswaran Manickavel
Cc: alim.akhtar, avri.altman, bvanassche, jejb, martin.petersen,
stanley.chu, mani, quic_cang, quic_asutoshd, peter.wang, beanhuo,
quic_nguyenb, Arthur.Simchaev, linux-scsi, linux-kernel
Bragatheswaran,
> A logical evaluation already results in bool. There is no need for
> using a ternary operator based evaluation and bool conversion of the
> outcome.
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ufs/core: ufshcd: Conversion to bool not necessary
2023-10-25 2:44 ` Martin K. Petersen
@ 2023-10-25 3:51 ` Bragatheswaran Manickavel
0 siblings, 0 replies; 4+ messages in thread
From: Bragatheswaran Manickavel @ 2023-10-25 3:51 UTC (permalink / raw)
To: Martin K. Petersen, bvanassche
Cc: alim.akhtar, avri.altman, jejb, stanley.chu, mani, quic_cang,
quic_asutoshd, peter.wang, beanhuo, quic_nguyenb, Arthur.Simchaev,
linux-scsi, linux-kernel
On 25/10/23 08:14, Martin K. Petersen wrote:
> Bragatheswaran,
>
>> A logical evaluation already results in bool. There is no need for
>> using a ternary operator based evaluation and bool conversion of the
>> outcome.
> Applied to 6.7/scsi-staging, thanks!
>
Thanks Bart Van and Martin!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-25 3:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 18:34 [PATCH] ufs/core: ufshcd: Conversion to bool not necessary Bragatheswaran Manickavel
2023-10-24 18:59 ` Bart Van Assche
2023-10-25 2:44 ` Martin K. Petersen
2023-10-25 3:51 ` Bragatheswaran Manickavel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox