[PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code

public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code
       [not found] <CGME20221118044223epcas1p12eab9a6fb08ec382625b3fb43f401e07@epcas1p1.samsung.com>
@ 2022-11-18  4:41 ` Chanwoo Lee
  2022-11-18  5:42   ` Stanley Chu
                     ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chanwoo Lee @ 2022-11-18  4:41 UTC (permalink / raw)
  To: stanley.chu, jejb, martin.petersen, matthias.bgg, linux-scsi,
	linux-mediatek
  Cc: ChanWoo Lee

From: ChanWoo Lee <cw9316.lee@samsung.com>

Remove unnecessary if/goto code.

Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
---
 drivers/ufs/host/ufs-mediatek.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 7309f3f87eac..7d13878dff47 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -441,8 +441,6 @@ static int ufs_mtk_mphy_power_on(struct ufs_hba *hba, bool on)
 		if (ufs_mtk_is_va09_supported(hba)) {
 			ufs_mtk_va09_pwr_ctrl(res, 0);
 			ret = regulator_disable(host->reg_va09);
-			if (ret < 0)
-				goto out;
 		}
 	}
 out:
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code
  2022-11-18  4:41 ` [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code Chanwoo Lee
@ 2022-11-18  5:42   ` Stanley Chu
  2022-11-18 10:38   ` AngeloGioacchino Del Regno
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Stanley Chu @ 2022-11-18  5:42 UTC (permalink / raw)
  To: Chanwoo Lee
  Cc: stanley.chu, jejb, martin.petersen, matthias.bgg, linux-scsi,
	linux-mediatek

On Fri, Nov 18, 2022 at 12:50 PM Chanwoo Lee <cw9316.lee@samsung.com> wrote:
>
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> Remove unnecessary if/goto code.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code
  2022-11-18  4:41 ` [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code Chanwoo Lee
  2022-11-18  5:42   ` Stanley Chu
@ 2022-11-18 10:38   ` AngeloGioacchino Del Regno
  2022-11-26  2:11   ` Martin K. Petersen
  2022-12-01  3:45   ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-18 10:38 UTC (permalink / raw)
  To: Chanwoo Lee, stanley.chu, jejb, martin.petersen, matthias.bgg,
	linux-scsi, linux-mediatek

Il 18/11/22 05:41, Chanwoo Lee ha scritto:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> Remove unnecessary if/goto code.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code
  2022-11-18  4:41 ` [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code Chanwoo Lee
  2022-11-18  5:42   ` Stanley Chu
  2022-11-18 10:38   ` AngeloGioacchino Del Regno
@ 2022-11-26  2:11   ` Martin K. Petersen
  2022-12-01  3:45   ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-11-26  2:11 UTC (permalink / raw)
  To: Chanwoo Lee
  Cc: stanley.chu, jejb, martin.petersen, matthias.bgg, linux-scsi,
	linux-mediatek


Chanwoo,

> Remove unnecessary if/goto code.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code
  2022-11-18  4:41 ` [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code Chanwoo Lee
                     ` (2 preceding siblings ...)
  2022-11-26  2:11   ` Martin K. Petersen
@ 2022-12-01  3:45   ` Martin K. Petersen
  3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2022-12-01  3:45 UTC (permalink / raw)
  To: linux-mediatek, matthias.bgg, jejb, Chanwoo Lee, linux-scsi,
	stanley.chu
  Cc: Martin K . Petersen

On Fri, 18 Nov 2022 13:41:36 +0900, Chanwoo Lee wrote:

> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> Remove unnecessary if/goto code.
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-mediatek: Remove unneeded code
      https://git.kernel.org/mkp/scsi/c/541555285339

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-12-01  3:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20221118044223epcas1p12eab9a6fb08ec382625b3fb43f401e07@epcas1p1.samsung.com>
2022-11-18  4:41 ` [PATCH] scsi: ufs: ufs-mediatek: Remove unneeded code Chanwoo Lee
2022-11-18  5:42   ` Stanley Chu
2022-11-18 10:38   ` AngeloGioacchino Del Regno
2022-11-26  2:11   ` Martin K. Petersen
2022-12-01  3:45   ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox