* [PATCH] qlogicpti: Return correct error code
@ 2016-02-17 13:32 Amitoj Kaur Chawla
2016-03-01 5:53 ` Seymour, Shane M
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Amitoj Kaur Chawla @ 2016-02-17 13:32 UTC (permalink / raw)
To: JBottomley, martin.petersen, linux-scsi, linux-kernel; +Cc: julia.lawall
The return value of of_ioremap on failure should be -ENODEV and not
-1.
Found using Coccinelle. A simplified version of the semantic patch
used is:
//<smpl>
@@
expression *e;
@@
e = of_ioremap(...);
if (e == NULL) {
...
return
- -1
+ -ENODEV
;
}
//</smpl>
The single call site only checks that the return value is less than 0,
hence no change is required at the call site.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/scsi/qlogicpti.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 676385f..69bfc0a 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -710,7 +710,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
"PTI Qlogic/ISP");
if (!qpti->qregs) {
printk("PTI: Qlogic/ISP registers are unmappable\n");
- return -1;
+ return -ENODEV;
}
if (qpti->is_pti) {
qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096),
@@ -718,7 +718,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
"PTI Qlogic/ISP statreg");
if (!qpti->sreg) {
printk("PTI: Qlogic/ISP status register is unmappable\n");
- return -1;
+ return -ENODEV;
}
}
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] qlogicpti: Return correct error code
2016-02-17 13:32 [PATCH] qlogicpti: Return correct error code Amitoj Kaur Chawla
@ 2016-03-01 5:53 ` Seymour, Shane M
2016-03-01 11:59 ` Hannes Reinecke
2016-03-02 1:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Seymour, Shane M @ 2016-03-01 5:53 UTC (permalink / raw)
To: Amitoj Kaur Chawla, JBottomley@odin.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: julia.lawall@lip6.fr
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qlogicpti: Return correct error code
2016-02-17 13:32 [PATCH] qlogicpti: Return correct error code Amitoj Kaur Chawla
2016-03-01 5:53 ` Seymour, Shane M
@ 2016-03-01 11:59 ` Hannes Reinecke
2016-03-02 1:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2016-03-01 11:59 UTC (permalink / raw)
To: Amitoj Kaur Chawla, JBottomley, martin.petersen, linux-scsi,
linux-kernel
Cc: julia.lawall
On 02/17/2016 09:32 PM, Amitoj Kaur Chawla wrote:
> The return value of of_ioremap on failure should be -ENODEV and not
> -1.
>
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
>
> //<smpl>
> @@
> expression *e;
> @@
>
> e = of_ioremap(...);
> if (e == NULL) {
> ...
> return
> - -1
> + -ENODEV
> ;
> }
> //</smpl>
>
> The single call site only checks that the return value is less than 0,
> hence no change is required at the call site.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/scsi/qlogicpti.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
> index 676385f..69bfc0a 100644
> --- a/drivers/scsi/qlogicpti.c
> +++ b/drivers/scsi/qlogicpti.c
> @@ -710,7 +710,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
> "PTI Qlogic/ISP");
> if (!qpti->qregs) {
> printk("PTI: Qlogic/ISP registers are unmappable\n");
> - return -1;
> + return -ENODEV;
> }
> if (qpti->is_pti) {
> qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096),
> @@ -718,7 +718,7 @@ static int qpti_map_regs(struct qlogicpti *qpti)
> "PTI Qlogic/ISP statreg");
> if (!qpti->sreg) {
> printk("PTI: Qlogic/ISP status register is unmappable\n");
> - return -1;
> + return -ENODEV;
> }
> }
> return 0;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qlogicpti: Return correct error code
2016-02-17 13:32 [PATCH] qlogicpti: Return correct error code Amitoj Kaur Chawla
2016-03-01 5:53 ` Seymour, Shane M
2016-03-01 11:59 ` Hannes Reinecke
@ 2016-03-02 1:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-03-02 1:08 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: linux-scsi, linux-kernel, julia.lawall, Shane M Seymour,
Hannes Reinecke
>>>>> "Amitoj" == Amitoj Kaur Chawla <amitoj1606@gmail.com> writes:
Amitoj> The return value of of_ioremap on failure should be -ENODEV and
Amitoj> not -1.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-02 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 13:32 [PATCH] qlogicpti: Return correct error code Amitoj Kaur Chawla
2016-03-01 5:53 ` Seymour, Shane M
2016-03-01 11:59 ` Hannes Reinecke
2016-03-02 1:08 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox