* [PATCH] scsi: lpfc: Use int type to store negative error codes
@ 2025-09-04 13:23 Qianfeng Rong
2025-09-04 16:35 ` Justin Tee
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qianfeng Rong @ 2025-09-04 13:23 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Cc: Qianfeng Rong
Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to int,
as it needs to store either negative error codes or zero returned by
lpfc_sli4_wq_put().
Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.
No effect on runtime.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index a8fbdf7119d8..8a2434a96919 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -21373,7 +21373,7 @@ lpfc_sli4_issue_wqe(struct lpfc_hba *phba, struct lpfc_sli4_hdw_queue *qp,
struct lpfc_sglq *sglq;
struct lpfc_sli_ring *pring;
unsigned long iflags;
- uint32_t ret = 0;
+ int ret = 0;
/* NVME_LS and NVME_LS ABTS requests. */
if (pwqe->cmd_flag & LPFC_IO_NVME_LS) {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: lpfc: Use int type to store negative error codes
2025-09-04 13:23 [PATCH] scsi: lpfc: Use int type to store negative error codes Qianfeng Rong
@ 2025-09-04 16:35 ` Justin Tee
2025-09-10 2:17 ` Martin K. Petersen
2025-09-17 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Justin Tee @ 2025-09-04 16:35 UTC (permalink / raw)
To: Qianfeng Rong
Cc: James Smart, Justin Tee, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Reviewed-by: Justin Tee <justin.tee@broadcom.com>
Regards,
Justin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: Use int type to store negative error codes
2025-09-04 13:23 [PATCH] scsi: lpfc: Use int type to store negative error codes Qianfeng Rong
2025-09-04 16:35 ` Justin Tee
@ 2025-09-10 2:17 ` Martin K. Petersen
2025-09-17 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-10 2:17 UTC (permalink / raw)
To: Qianfeng Rong
Cc: James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Qianfeng,
> Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to
> int, as it needs to store either negative error codes or zero returned
> by lpfc_sli4_wq_put().
Applied to 6.18/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: Use int type to store negative error codes
2025-09-04 13:23 [PATCH] scsi: lpfc: Use int type to store negative error codes Qianfeng Rong
2025-09-04 16:35 ` Justin Tee
2025-09-10 2:17 ` Martin K. Petersen
@ 2025-09-17 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-17 2:27 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E.J. Bottomley, linux-scsi,
linux-kernel, Qianfeng Rong
Cc: Martin K . Petersen
On Thu, 04 Sep 2025 21:23:51 +0800, Qianfeng Rong wrote:
> Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to int,
> as it needs to store either negative error codes or zero returned by
> lpfc_sli4_wq_put().
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> [...]
Applied to 6.18/scsi-queue, thanks!
[1/1] scsi: lpfc: Use int type to store negative error codes
https://git.kernel.org/mkp/scsi/c/5cffc679ad1d
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-17 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 13:23 [PATCH] scsi: lpfc: Use int type to store negative error codes Qianfeng Rong
2025-09-04 16:35 ` Justin Tee
2025-09-10 2:17 ` Martin K. Petersen
2025-09-17 2:27 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox