* [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion
@ 2025-02-26 2:11 Jiapeng Chong
2025-02-26 6:49 ` Shawn Lin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiapeng Chong @ 2025-02-26 2:11 UTC (permalink / raw)
To: James.Bottomley
Cc: martin.petersen, heiko, linux-scsi, linux-arm-kernel,
linux-rockchip, linux-kernel, Jiapeng Chong, Abaci Robot
./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19055
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/ufs/host/ufs-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
index 5b0ea9820767..350cb0f8d0c2 100644
--- a/drivers/ufs/host/ufs-rockchip.c
+++ b/drivers/ufs/host/ufs-rockchip.c
@@ -265,7 +265,7 @@ static int ufs_rockchip_runtime_suspend(struct device *dev)
clk_disable_unprepare(host->ref_out_clk);
/* Do not power down the genpd if rpm_lvl is less than level 5 */
- dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5 ? true : false);
+ dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5);
return ufshcd_runtime_suspend(dev);
}
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion
2025-02-26 2:11 [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion Jiapeng Chong
@ 2025-02-26 6:49 ` Shawn Lin
2025-03-04 2:26 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Lin @ 2025-02-26 6:49 UTC (permalink / raw)
To: Jiapeng Chong
Cc: shawn.lin, martin.petersen, heiko, linux-scsi, linux-arm-kernel,
linux-rockchip, linux-kernel, Abaci Robot, James.Bottomley
在 2025/2/26 10:11, Jiapeng Chong 写道:
> ./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19055
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
Thanks Jiapeng.
> ---
> drivers/ufs/host/ufs-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
> index 5b0ea9820767..350cb0f8d0c2 100644
> --- a/drivers/ufs/host/ufs-rockchip.c
> +++ b/drivers/ufs/host/ufs-rockchip.c
> @@ -265,7 +265,7 @@ static int ufs_rockchip_runtime_suspend(struct device *dev)
> clk_disable_unprepare(host->ref_out_clk);
>
> /* Do not power down the genpd if rpm_lvl is less than level 5 */
> - dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5 ? true : false);
> + dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5);
>
> return ufshcd_runtime_suspend(dev);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion
2025-02-26 2:11 [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion Jiapeng Chong
2025-02-26 6:49 ` Shawn Lin
@ 2025-03-04 2:26 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-03-04 2:26 UTC (permalink / raw)
To: Jiapeng Chong
Cc: James.Bottomley, martin.petersen, heiko, linux-scsi,
linux-arm-kernel, linux-rockchip, linux-kernel, Abaci Robot
Jiapeng,
> ./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion
2025-02-26 2:11 [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion Jiapeng Chong
2025-02-26 6:49 ` Shawn Lin
2025-03-04 2:26 ` Martin K. Petersen
@ 2025-03-11 1:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-03-11 1:19 UTC (permalink / raw)
To: James.Bottomley, Jiapeng Chong
Cc: Martin K . Petersen, heiko, linux-scsi, linux-arm-kernel,
linux-rockchip, linux-kernel, Abaci Robot
On Wed, 26 Feb 2025 10:11:57 +0800, Jiapeng Chong wrote:
> ./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
>
>
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: ufs: rockchip: Simplify bool conversion
https://git.kernel.org/mkp/scsi/c/3d8256903934
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-11 1:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 2:11 [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion Jiapeng Chong
2025-02-26 6:49 ` Shawn Lin
2025-03-04 2:26 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox