From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: sumit.saxena@broadcom.com
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org
Subject: Re: megaraid_sas: Task management support
Date: Thu, 11 Feb 2016 10:18:50 -0500 [thread overview]
Message-ID: <yq1y4ar46n9.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160208182130.GB18802@mwanda> (Dan Carpenter's message of "Mon, 8 Feb 2016 21:21:30 +0300")
Sumit,
Please comment.
Thanks!
---8<---
Hello Sumit Saxena,
The patch 31796fa184ee: "megaraid_sas: Task management support" from
Jan 28, 2016, leads to the following static checker warning:
drivers/scsi/megaraid/megaraid_sas_base.c:1788 megasas_update_sdev_properties()
warn: if statement not indented
drivers/scsi/megaraid/megaraid_sas_base.c
1781 } else {
1782 device_id = ((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL)
1783 + sdev->id;
1784 local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
1785 ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
1786 raid = MR_LdRaidGet(ld, local_map_ptr);
1787
1788 if (raid->capability.ldPiMode == MR_PROT_INFO_TYPE_CONTROLLER)
1789 blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
It looks like the code is correct but the patch just deleted a tab
accidentally.
1790 mr_device_priv_data->is_tm_capable =
1791 raid->capability.tmCapable;
1792 }
---8<---
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-02-11 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 18:21 megaraid_sas: Task management support Dan Carpenter
2016-02-11 15:18 ` Martin K. Petersen [this message]
2016-02-12 9:22 ` Sumit Saxena
2016-02-12 17:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y4ar46n9.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox