* re: megaraid_sas: Task management support
@ 2016-02-08 18:21 Dan Carpenter
2016-02-11 15:18 ` Martin K. Petersen
2016-02-12 9:22 ` Sumit Saxena
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-02-08 18:21 UTC (permalink / raw)
To: sumit.saxena; +Cc: megaraidlinux.pdl, linux-scsi
Hello Sumit Saxena,
The patch 31796fa184ee: "megaraid_sas: Task management support" from
Jan 28, 2016, leads to the following static checker warning:
drivers/scsi/megaraid/megaraid_sas_base.c:1788 megasas_update_sdev_properties()
warn: if statement not indented
drivers/scsi/megaraid/megaraid_sas_base.c
1781 } else {
1782 device_id = ((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL)
1783 + sdev->id;
1784 local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
1785 ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
1786 raid = MR_LdRaidGet(ld, local_map_ptr);
1787
1788 if (raid->capability.ldPiMode == MR_PROT_INFO_TYPE_CONTROLLER)
1789 blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
It looks like the code is correct but the patch just deleted a tab
accidentally.
1790 mr_device_priv_data->is_tm_capable =
1791 raid->capability.tmCapable;
1792 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: megaraid_sas: Task management support
2016-02-08 18:21 megaraid_sas: Task management support Dan Carpenter
@ 2016-02-11 15:18 ` Martin K. Petersen
2016-02-12 9:22 ` Sumit Saxena
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-02-11 15:18 UTC (permalink / raw)
To: sumit.saxena; +Cc: Dan Carpenter, megaraidlinux.pdl, linux-scsi
Sumit,
Please comment.
Thanks!
---8<---
Hello Sumit Saxena,
The patch 31796fa184ee: "megaraid_sas: Task management support" from
Jan 28, 2016, leads to the following static checker warning:
drivers/scsi/megaraid/megaraid_sas_base.c:1788 megasas_update_sdev_properties()
warn: if statement not indented
drivers/scsi/megaraid/megaraid_sas_base.c
1781 } else {
1782 device_id = ((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL)
1783 + sdev->id;
1784 local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
1785 ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
1786 raid = MR_LdRaidGet(ld, local_map_ptr);
1787
1788 if (raid->capability.ldPiMode == MR_PROT_INFO_TYPE_CONTROLLER)
1789 blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
It looks like the code is correct but the patch just deleted a tab
accidentally.
1790 mr_device_priv_data->is_tm_capable =
1791 raid->capability.tmCapable;
1792 }
---8<---
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: megaraid_sas: Task management support
2016-02-08 18:21 megaraid_sas: Task management support Dan Carpenter
2016-02-11 15:18 ` Martin K. Petersen
@ 2016-02-12 9:22 ` Sumit Saxena
2016-02-12 17:07 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Sumit Saxena @ 2016-02-12 9:22 UTC (permalink / raw)
To: Dan Carpenter, sumit.saxena; +Cc: megaraidlinux.pdl, linux-scsi
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Monday, February 08, 2016 11:52 PM
> To: sumit.saxena@avagotech.com
> Cc: megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org
> Subject: re: megaraid_sas: Task management support
>
> Hello Sumit Saxena,
>
> The patch 31796fa184ee: "megaraid_sas: Task management support" from Jan
> 28, 2016, leads to the following static checker warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c:1788
> megasas_update_sdev_properties()
> warn: if statement not indented
>
> drivers/scsi/megaraid/megaraid_sas_base.c
> 1781 } else {
> 1782 device_id = ((sdev->channel % 2) *
> MEGASAS_MAX_DEV_PER_CHANNEL)
> 1783 + sdev->id;
> 1784 local_map_ptr =
fusion->ld_drv_map[(instance->map_id & 1)];
> 1785 ld = MR_TargetIdToLdGet(device_id,
local_map_ptr);
> 1786 raid = MR_LdRaidGet(ld, local_map_ptr);
> 1787
> 1788 if (raid->capability.ldPiMode ==
> MR_PROT_INFO_TYPE_CONTROLLER)
> 1789
blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
>
> It looks like the code is correct but the patch just deleted a tab
accidentally.
Yes code is correct, tab got deleted accidentally.
>
> 1790 mr_device_priv_data->is_tm_capable =
> 1791 raid->capability.tmCapable;
> 1792 }
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: megaraid_sas: Task management support
2016-02-12 9:22 ` Sumit Saxena
@ 2016-02-12 17:07 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-02-12 17:07 UTC (permalink / raw)
To: Sumit Saxena; +Cc: Dan Carpenter, sumit.saxena, megaraidlinux.pdl, linux-scsi
>>>>> "Sumit" == Sumit Saxena <sumit.saxena@broadcom.com> writes:
Sumit,
>> It looks like the code is correct but the patch just deleted a tab
Sumit> Yes code is correct, tab got deleted accidentally.
Please submit a patch to correct the formatting.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-12 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 18:21 megaraid_sas: Task management support Dan Carpenter
2016-02-11 15:18 ` Martin K. Petersen
2016-02-12 9:22 ` Sumit Saxena
2016-02-12 17:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox